From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v5-resend 4/7] ASoC: sirf: Add SiRF I2S
	driver
Date: Fri, 7 Mar 2014 14:05:16 +0800
Message-ID: <20140307060516.GE13126@sirena.org.uk>
References: <1394008480-29135-1-git-send-email-rongjun.ying@csr.com>
 <1394008480-29135-5-git-send-email-rongjun.ying@csr.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3244843275662016744=="
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk
 [106.187.55.193])
 by alsa0.perex.cz (Postfix) with ESMTP id 6DCB72659A8
 for <alsa-devel@alsa-project.org>; Fri,  7 Mar 2014 07:22:50 +0100 (CET)
In-Reply-To: <1394008480-29135-5-git-send-email-rongjun.ying@csr.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: RongJun Ying <rjying@gmail.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>, workgroup.linux@csr.com, Rongjun Ying <rongjun.ying@csr.com>
List-Id: alsa-devel@alsa-project.org


--===============3244843275662016744==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="NzGUbf6j8lrSeJQO"
Content-Disposition: inline


--NzGUbf6j8lrSeJQO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 05, 2014 at 04:34:37PM +0800, RongJun Ying wrote:

Mostly OK, a couple of small things below:

> +static int sirf_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id,
> +	int src_rate)
> +{
> +	struct sirf_i2s *i2s = snd_soc_dai_get_drvdata(dai);
> +
> +	switch (div_id) {
> +	case SIRF_I2S_EXT_CLK:
> +		i2s->ext_clk = 1;
> +		break;
> +	case SIRF_I2S_PWM_CLK:
> +		i2s->ext_clk = 0;
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	i2s->src_clk_rate = src_rate;
> +	return 0;
> +}

This should be set_sysclk().

> +	base = devm_ioremap(&pdev->dev, mem_res->start,
> +		resource_size(mem_res));
> +	if (base == NULL)
> +		return -ENOMEM;

As mentioned on the other patch this should be devm_ioremap_resource() -
if you are sharing the register range use a core device to own the
register map.

--NzGUbf6j8lrSeJQO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJTGWGZAAoJELSic+t+oim9zBsP/R4P3usDxld8IvwP3k1xiaCX
BR06jCU/7bv02ivI2PHAaHJnFpem1ib+wDs1tqGYsRBbIiJToOgL+ZKSfbKyPQYZ
cC/PwyskFH1OW55pRbhXQgP/VQF5QXscncBP/LC+FP8DanP71iuSts48vJrtrO6B
ZNAUSQYpx1CUZEye1qALS6sWCEA7jY1hgtzOLHgCKyvJq9vQ3ICjIPyN8czuAMe9
k2Jc2Zq4hII6lQFpiEGDSJkvZcNdELpWQ7V0Ht2pFPydwgnCL4kDrRnBrDqBJq8j
N/loYtPt66Yu3+0Z6LcFBzZtG12OTNuUoO2tq8rIexKZFvV52gjt3gshdDtbWOSi
V687agj9piTF/7QBzS7ww+Xsd24gDWVizgZe3MT6C48AisfCQqRHp33+x8tUsnmt
qZN1BxzXg6eRmh8IJBG/LALXu13gOwvzD3zQ0XJmFRXPgWg7e7UzhYWRC+GLUEUo
YapTd4i6uHRmQ+5wsVwlYuMmuRNdiWsw+xSl/hgCxR8mgkbZ1PqDspvoXImn+YZy
pEIGQX2zSzUu47Qxtegci6qt/HKBEKDsjpPkdZLC6LBIvbaiFBrN0qJZOJbHIP7H
YUv2ZoA/I3QCOGUNy+90rIZBd+oTxhLHVpHw1nEErqAiZSDrTMe4se1LC0aKZSKH
T1QirMnmlJxKr8xlH2s6
=+IyJ
-----END PGP SIGNATURE-----

--NzGUbf6j8lrSeJQO--

--===============3244843275662016744==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--===============3244843275662016744==--