From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kuninori.morimoto.gx@renesas.com, moinejf@free.fr,
Li.Xiubo@freescale.com, lgirdwood@gmail.com,
Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH] ASoC: simple-card: overwrite DAIFMT_MASTER of cpu_dai->fmt
Date: Wed, 12 Mar 2014 10:01:24 +0800 [thread overview]
Message-ID: <20140312020123.GC1177@MrMyself> (raw)
In-Reply-To: <20140311132553.GR28112@sirena.org.uk>
On Tue, Mar 11, 2014 at 01:25:53PM +0000, Mark Brown wrote:
> On Tue, Mar 11, 2014 at 08:54:32PM +0800, Nicolin Chen wrote:
>
> Adding Jyri who's been looking at this as well but not added anyone else
> working on simple-card so you might've missed his mails.
>
> > It's pretty fair to do it for DAIFMT_INV since two dais might have differnt
> > definitions in their drivers even though it'd be better to keep it same if
> > we could.
>
> No, that's not at all OK - anything that requires this is broken. The
> same DAI format should be usable by both ends of the link unless the
> board itself is inverting one of the signals or something.
That makes sense to me. Okay, I'll overwrite them all...
>
> > Thus this patch fixes it by overwriting the DAIFMT_MASTER bit of cpu_dai->fmt
> > with the one of codec_dai->fmt since we defined DAIFMT_MASTER basing on CODEC
> > at the first place.
>
> This seems closer to what I'd expect for something like this but it does
> mean that any format settings on the CPU DAI will be ignored (rather
> than say warning or something). I'm not sure this is a bad thing
> though, probably wants the binding documenting at least.
...along with the binding doc.
next prev parent reply other threads:[~2014-03-12 2:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 12:54 [PATCH] ASoC: simple-card: overwrite DAIFMT_MASTER of cpu_dai->fmt Nicolin Chen
2014-03-11 13:25 ` Mark Brown
2014-03-12 2:01 ` Nicolin Chen [this message]
2014-03-12 1:32 ` [alsa-devel] " Kuninori Morimoto
2014-03-12 1:49 ` Mark Brown
2014-03-12 3:36 ` Kuninori Morimoto
2014-03-12 3:26 ` Nicolin Chen
2014-03-12 4:01 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312020123.GC1177@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jsarha@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).