From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: Jyri Sarha <jsarha@ti.com>,
mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
Li.Xiubo@freescale.com, linux-doc@vger.kernel.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, rob@landley.net, galak@codeaurora.org,
moinejf@free.fr
Subject: Re: [alsa-devel] [PATCH v2] ASoC: simple-card: overwrite cpu_dai->fmt with codec_dai->fmt
Date: Thu, 13 Mar 2014 21:20:55 +0000 [thread overview]
Message-ID: <20140313212055.GN366@sirena.org.uk> (raw)
In-Reply-To: <20140312093353.GH1177@MrMyself>
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
On Wed, Mar 12, 2014 at 05:33:54PM +0800, Nicolin Chen wrote:
> I'm not sure if there's any defect from this idea, but as long as we
> keep DAIFMT settings identical for both dai-link ends, it'll be a
> neater way.
> So I'd like to pend this patch and wait for further solution from that
> topic.
My understanding of the binding had been that exactly one of the devices
on the link would have each master flag set and the code was parsing
both devices together in order to come up with the setting. Obviously I
didn't check the code closely enough here. It seems that the Renesas
devices actually do this, though just due to a bug in the master/slave
handling. The patch you posted would essentially implement that
(without validating the settings on the CPU side, but that could be
added).
The above suggestion would also work though it *is* a change in the
binding and right now we don't have code for it. We need something here
very soon, the merge window is going to open shortly and we ought to
avoid having the problematic code in v3.15 if we can - indeed I'd really
prefer to get something into v3.14 if possible (though this patch
doesn't apply cleanly there and it's *very* late).
Thoughts?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-13 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 3:02 [PATCH v2] ASoC: simple-card: overwrite cpu_dai->fmt with codec_dai->fmt Nicolin Chen
2014-03-12 9:25 ` Jyri Sarha
[not found] ` <5320280C.6080004-l0cyMroinI0@public.gmane.org>
2014-03-12 9:33 ` [alsa-devel] " Nicolin Chen
2014-03-13 21:20 ` Mark Brown [this message]
2014-03-18 20:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313212055.GN366@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Guangyu.Chen@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jsarha@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=moinejf@free.fr \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).