From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Morimoto <kuninori.morimoto.gx@renesas.com>,
Linux-SH <linux-sh@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/2][RFC] ASoC: fsi: fixup SND_SOC_DAIFMT_CBx_CFx flags
Date: Fri, 14 Mar 2014 08:55:50 +0900 [thread overview]
Message-ID: <20140313235548.GA4691@verge.net.au> (raw)
In-Reply-To: <87siqnrjyl.wl%kuninori.morimoto.gx@gmail.com>
On Tue, Mar 11, 2014 at 11:48:21PM -0700, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> SND_SOC_DAIFMT_CBx_CFx means "codec" side master/slave mode.
> Then, FSI will be master mode if it was SND_SOC_DAIFMT_CBS_CFS.
>
> This patch fixup platform settings too.
> Then, it tidyups SND_SOC_DAIFMT_INV settings.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
arch/arm/mach-shmobile bits:
Acked-by: Simon Horman <horms+renesas@verge.net.au>
N.B: arch/sh/ is now orphaned.
> ---
> .../boot/dts/r8a7740-armadillo800eva-reference.dts | 3 ++-
> arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 2 ++
> arch/arm/mach-shmobile/board-armadillo800eva.c | 4 +---
> arch/arm/mach-shmobile/board-kzm9g.c | 4 +---
> arch/arm/mach-shmobile/board-mackerel.c | 6 ++----
> arch/sh/boards/mach-ecovec24/setup.c | 4 +---
> arch/sh/boards/mach-se/7724/setup.c | 4 +---
> sound/soc/sh/fsi.c | 2 +-
> 8 files changed, 11 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> index 95a849b..acffbab 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> @@ -135,7 +135,8 @@
>
> simple-audio-card,cpu {
> sound-dai = <&sh_fsi2 0>;
> - bitclock-inversion;
> + bitclock-master;
> + frame-master;
> };
>
> simple-audio-card,codec {
> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> index eb8886b..68da428 100644
> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> @@ -158,6 +158,8 @@
> simple-audio-card,format = "left_j";
> simple-audio-card,cpu {
> sound-dai = <&sh_fsi2 0>;
> + bitclock-master;
> + frame-master;
> };
> simple-audio-card,codec {
> sound-dai = <&ak4648>;
> diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
> index 93533e2..9323854 100644
> --- a/arch/arm/mach-shmobile/board-armadillo800eva.c
> +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
> @@ -988,14 +988,12 @@ static struct asoc_simple_card_info fsi_wm8978_info = {
> .card = "FSI2A-WM8978",
> .codec = "wm8978.0-001a",
> .platform = "sh_fsi2",
> - .daifmt = SND_SOC_DAIFMT_I2S,
> + .daifmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM,
> .cpu_dai = {
> .name = "fsia-dai",
> - .fmt = SND_SOC_DAIFMT_CBS_CFS | SND_SOC_DAIFMT_IB_NF,
> },
> .codec_dai = {
> .name = "wm8978-hifi",
> - .fmt = SND_SOC_DAIFMT_CBM_CFM | SND_SOC_DAIFMT_NB_NF,
> .sysclk = 12288000,
> },
> };
> diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
> index bc40b85..03dc3ac 100644
> --- a/arch/arm/mach-shmobile/board-kzm9g.c
> +++ b/arch/arm/mach-shmobile/board-kzm9g.c
> @@ -589,14 +589,12 @@ static struct asoc_simple_card_info fsi2_ak4648_info = {
> .card = "FSI2A-AK4648",
> .codec = "ak4642-codec.0-0012",
> .platform = "sh_fsi2",
> - .daifmt = SND_SOC_DAIFMT_LEFT_J,
> + .daifmt = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBM_CFM,
> .cpu_dai = {
> .name = "fsia-dai",
> - .fmt = SND_SOC_DAIFMT_CBS_CFS,
> },
> .codec_dai = {
> .name = "ak4642-hifi",
> - .fmt = SND_SOC_DAIFMT_CBM_CFM,
> .sysclk = 11289600,
> },
> };
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 3aba037..8c43321 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -509,9 +509,9 @@ static struct asoc_simple_card_info fsi2_hdmi_info = {
> .card = "FSI2B-HDMI",
> .codec = "sh-mobile-hdmi",
> .platform = "sh_fsi2",
> + .fmt = SND_SOC_DAIFMT_CBS_CFS,
> .cpu_dai = {
> .name = "fsib-dai",
> - .fmt = SND_SOC_DAIFMT_CBM_CFM | SND_SOC_DAIFMT_IB_NF,
> },
> .codec_dai = {
> .name = "sh_mobile_hdmi-hifi",
> @@ -905,14 +905,12 @@ static struct asoc_simple_card_info fsi2_ak4643_info = {
> .card = "FSI2A-AK4643",
> .codec = "ak4642-codec.0-0013",
> .platform = "sh_fsi2",
> - .daifmt = SND_SOC_DAIFMT_LEFT_J,
> + .daifmt = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBM_CFM,
> .cpu_dai = {
> .name = "fsia-dai",
> - .fmt = SND_SOC_DAIFMT_CBS_CFS,
> },
> .codec_dai = {
> .name = "ak4642-hifi",
> - .fmt = SND_SOC_DAIFMT_CBM_CFM,
> .sysclk = 11289600,
> },
> };
> diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
> index 5bc3a15..85d5255 100644
> --- a/arch/sh/boards/mach-ecovec24/setup.c
> +++ b/arch/sh/boards/mach-ecovec24/setup.c
> @@ -861,14 +861,12 @@ static struct asoc_simple_card_info fsi_da7210_info = {
> .card = "FSIB-DA7210",
> .codec = "da7210.0-001a",
> .platform = "sh_fsi.0",
> - .daifmt = SND_SOC_DAIFMT_I2S,
> + .daifmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM,
> .cpu_dai = {
> .name = "fsib-dai",
> - .fmt = SND_SOC_DAIFMT_CBS_CFS | SND_SOC_DAIFMT_IB_NF,
> },
> .codec_dai = {
> .name = "da7210-hifi",
> - .fmt = SND_SOC_DAIFMT_CBM_CFM,
> },
> };
>
> diff --git a/arch/sh/boards/mach-se/7724/setup.c b/arch/sh/boards/mach-se/7724/setup.c
> index 21e4230..1162bc6 100644
> --- a/arch/sh/boards/mach-se/7724/setup.c
> +++ b/arch/sh/boards/mach-se/7724/setup.c
> @@ -304,14 +304,12 @@ static struct asoc_simple_card_info fsi_ak4642_info = {
> .card = "FSIA-AK4642",
> .codec = "ak4642-codec.0-0012",
> .platform = "sh_fsi.0",
> - .daifmt = SND_SOC_DAIFMT_LEFT_J,
> + .daifmt = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBM_CFM,
> .cpu_dai = {
> .name = "fsia-dai",
> - .fmt = SND_SOC_DAIFMT_CBS_CFS | SND_SOC_DAIFMT_IB_NF,
> },
> .codec_dai = {
> .name = "ak4642-hifi",
> - .fmt = SND_SOC_DAIFMT_CBM_CFM,
> .sysclk = 11289600,
> },
> };
> diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
> index 1967f44..710a079 100644
> --- a/sound/soc/sh/fsi.c
> +++ b/sound/soc/sh/fsi.c
> @@ -1711,9 +1711,9 @@ static int fsi_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
> /* set master/slave audio interface */
> switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> case SND_SOC_DAIFMT_CBM_CFM:
> - fsi->clk_master = 1;
> break;
> case SND_SOC_DAIFMT_CBS_CFS:
> + fsi->clk_master = 1; /* codec is slave, cpu is master */
> break;
> default:
> return -EINVAL;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-03-13 23:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 6:47 [PATCH 0/2][RFC] ASoC: fsi/rcar: fixup SND_SOC_DAIFMT_CBx_CFx flags Kuninori Morimoto
2014-03-12 6:48 ` [PATCH 1/2][RFC] ASoC: fsi: " Kuninori Morimoto
2014-03-13 23:55 ` Simon Horman [this message]
2014-03-12 6:48 ` [PATCH 2/2][RFC] ASoC: rcar: " Kuninori Morimoto
2014-03-13 10:48 ` [PATCH 0/2][RFC] ASoC: fsi/rcar: " Mark Brown
2014-03-13 23:55 ` Kuninori Morimoto
2014-03-13 23:55 ` Simon Horman
2014-03-14 10:26 ` Mark Brown
2014-03-17 0:15 ` Simon Horman
2014-03-14 0:54 ` [PATCH 0/2 v2] " Kuninori Morimoto
2014-03-14 0:56 ` [PATCH 1/2 v2] ASoC: fsi: " Kuninori Morimoto
2014-03-14 19:31 ` Mark Brown
2014-03-14 0:56 ` [PATCH 2/2] ASoC: rcar: " Kuninori Morimoto
2014-03-14 19:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313235548.GA4691@verge.net.au \
--to=horms@verge.net.au \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).