From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [alsa-devel] [PATCH v2 3/4] ASoC: simple-card: accept many DAI links Date: Fri, 14 Mar 2014 19:40:37 +0100 Message-ID: <20140314194037.7da888cd@armhf> References: <5322E4FC.7060605@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <5322E4FC.7060605@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Jyri Sarha Cc: Mark Brown , alsa-devel@alsa-project.org, Xiubo Li , linux-kernel@vger.kernel.org, Kuninori Morimoto List-Id: alsa-devel@alsa-project.org On Fri, 14 Mar 2014 13:16:12 +0200 Jyri Sarha wrote: > On 03/11/2014 11:36 AM, Jean-Francois Moine wrote: > > Some simple audio cards may have many DAI links. > > This patch extends the simple-card driver for handling such cards. > > > > Signed-off-by: Jean-Francois Moine > > --- > [...] >=20 > Why can't you just use two simple-card instances in your setup? My machine has only one audio device (kirkwood). This one has two outputs. The first one (I2S) is connected to the HDMI transmitter, and the other one (S/PDIF) is connected to both the HDMI transmitter and th= e S/PDIF connector. There can be only one playback stream, either via I2S, or S/PDIF, or both, with the final output either to HDMI or S/PDIF or both: /--> I2S -----+-> HDMI platform -+ / \-> S/PDIF -+ \--> S/PDIF DPCM permits to activate both I2S and S/PDIF, but it does not handle the format and rate constraints (both outputs are always activated with the platform constraints). So, the actual solution I use is 3 DAI links (=3D 3 PCMs): - HDMI via I2S - HDMI via S/PDIF (no S/PDIF output) - S/PDIF via S/PDIF (no HDMI output) > You need to update the DT-binding document too when you are changing = the=20 > binding. That way it would also be easier to follow what you are tryi= ng=20 > to accomplish here. Some people want to have 2 different patchs: one for the code and the other one for the DT change. Some other people like you want only one patch. Which is the right way? > The sysclk and tdm properties appear to only work in the dais of the=20 > first dai-link and __asoc_simple_card_dai_init() will not be called f= or=20 > other dais at all. The DT-binding of this implementation would look=20 > pretty hairy to me. I will add an other dynamic structure for these properties. --=20 Ken ar c'henta=C3=B1 | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/