From: Mark Brown <broonie@kernel.org>
To: Bard Liao <bardliao@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
Flove <flove@realtek.com>,
Gustaw Lewandowski <gustaw.lewandowski@intel.com>
Subject: Re: [PATCH v5] ASoC: add RT286 CODEC driver
Date: Fri, 21 Mar 2014 12:12:04 +0000 [thread overview]
Message-ID: <20140321121204.GO11706@sirena.org.uk> (raw)
In-Reply-To: <ABFD875FF5FB574BA706497D987D48D73A3762@RTITMBSV03.realtek.com.tw>
[-- Attachment #1.1: Type: text/plain, Size: 1068 bytes --]
On Fri, Mar 21, 2014 at 05:57:49AM +0000, Bard Liao wrote:
> > Please fix your mailer to word wrap within paragraphs, this will make your mail
> > more legible.
> Now I set 80 characters to wrap the text. Hope it can work.
Doesn't seem to have taken I'm afraid :(
> > So VID+NID is an address and PID is a value?
> For I2C write, yes.
> But for I2C read, I think PID is also a part of address. Because PID is meaningful in the I2C read protocol.
> For example, if we need to get the mute/unmute status of headphone, we need to set:
> VID = b'h (Get Amplifier Gain)
> NID = 22'h (Headhoone)
> PID = a000'h (Left output amplifier gain is requested)
> And we can get response from rt286.
> I am trying to implement my reg_write and reg_read to:
> reg_write: address: VID+NID, value: PID
> reg_read: address: VID+NID+PID, value: the responding data from rt286.
Right, that's why I said you'll need to read the cache as part of your
read function. Unless the PID there is not the last value that was set
in which case it probably isn't actually a register value...
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-03-21 12:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 7:11 [PATCH v5] ASoC: add RT286 CODEC driver bardliao
2014-03-12 21:15 ` Lars-Peter Clausen
2014-03-13 5:29 ` Bard Liao
2014-03-13 8:35 ` Lars-Peter Clausen
2014-03-13 8:52 ` Takashi Iwai
2014-03-13 19:29 ` Mark Brown
2014-03-13 20:04 ` Takashi Iwai
2014-03-13 20:43 ` Mark Brown
2014-03-14 9:38 ` Bard Liao
2014-03-14 10:16 ` Mark Brown
2014-03-14 19:12 ` Mark Brown
2014-03-18 12:41 ` Bard Liao
2014-03-18 13:01 ` Mark Brown
2014-03-21 5:57 ` Bard Liao
2014-03-21 12:12 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321121204.GO11706@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=gustaw.lewandowski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).