From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org,
jsarha@ti.com
Subject: Re: [PATCH] ASoC: davinci-mcasp: Fix ruledata setup in davinci_mcasp_startup
Date: Tue, 7 Apr 2015 12:05:52 +0100 [thread overview]
Message-ID: <20150407110552.GE6023@sirena.org.uk> (raw)
In-Reply-To: <1428404633-25365-1-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 408 bytes --]
On Tue, Apr 07, 2015 at 02:03:53PM +0300, Peter Ujfalusi wrote:
> Passing &mcasp->ruledata[dir] to snd_pcm_hw_rule_add() is not correct since
> commit:
> 7b3d165a2821 ASoC: davinci-mcasp: Index ruledata in drvdata with substream->stream
> now sets up the struct based on the substream->stream (0 or 1) while we pass
> a pointer which we take with dir (1 or 2). This will lead kernel crash.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2015-04-07 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 11:03 [PATCH] ASoC: davinci-mcasp: Fix ruledata setup in davinci_mcasp_startup Peter Ujfalusi
2015-04-07 11:05 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407110552.GE6023@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).