From: Mark Brown <broonie@kernel.org>
To: Bard Liao <bardliao@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Nicolas Boichat <drinkcat@chromium.org>,
Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>,
"koro.chen@mediatek.com" <koro.chen@mediatek.com>
Subject: Re: [PATCH v2 1/3] ASoC: rt5645: Simplify rt5645_enable_push_button_irq
Date: Tue, 14 Jul 2015 11:28:33 +0100 [thread overview]
Message-ID: <20150714102833.GP11162@sirena.org.uk> (raw)
In-Reply-To: <ABFD875FF5FB574BA706497D987D48D70108A904@RTITMBSV03.realtek.com.tw>
[-- Attachment #1.1: Type: text/plain, Size: 655 bytes --]
On Tue, Jul 14, 2015 at 10:09:44AM +0000, Bard Liao wrote:
> Thanks for the review. I think what we need is something like
> + snd_soc_dapm_force_enable_pin(dapm, "ADC L power");
> + snd_soc_dapm_force_enable_pin(dapm, "ADC R power");
> + snd_soc_dapm_sync(dapm);
> + if (!codec->component.card->instantiated) {
> + regmap_update_bits(rt5645->regmap, RT5645_PWR_DIG1,
> + RT5645_PWR_ADC_L_BIT | RT5645_PWR_ADC_R_BIT,
> + RT5645_PWR_ADC_L_BIT | RT5645_PWR_ADC_R_BIT);
> + }
Yes, that's more what I'd expect. You could probably just do the regmap
update unconditionally since it shouldn't make any difference but it's a
bit neater this way.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-07-14 10:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 6:51 [PATCH v2 0/3] ASoC: rt5645: Remove codec dependency in workqueue handler Nicolas Boichat
2015-07-14 6:51 ` [PATCH v2 1/3] ASoC: rt5645: Simplify rt5645_enable_push_button_irq Nicolas Boichat
2015-07-14 9:48 ` Bard Liao
2015-07-14 9:52 ` Mark Brown
2015-07-14 10:09 ` Bard Liao
2015-07-14 10:28 ` Mark Brown [this message]
2015-07-15 1:05 ` Nicolas Boichat
2015-07-15 8:50 ` Mark Brown
2015-07-15 11:50 ` Nicolas Boichat
2015-07-15 11:56 ` Mark Brown
2015-07-15 13:03 ` Bard Liao
2015-07-16 3:05 ` Nicolas Boichat
2015-07-14 6:51 ` [PATCH v2 2/3] ASoC: rt5645: Remove irq_jack_detection function Nicolas Boichat
2015-07-15 11:55 ` Applied "ASoC: rt5645: Remove irq_jack_detection function" to the asoc tree Mark Brown
2015-07-14 6:51 ` [PATCH v2 3/3] ASoC: rt5645: Remove codec dependency in workqueue handler Nicolas Boichat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714102833.GP11162@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=drinkcat@chromium.org \
--cc=koro.chen@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).