From: Robert Rosengren <robert.rosengren@axis.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Robert Rosengren <robertr@axis.com>,
Danny Smith <dannys@axis.com>
Subject: [PATCH v2 2/2] ASoC: adau17x1: Do not reload dsp-fw if samplerate has not changed
Date: Mon, 9 Apr 2018 15:13:36 +0200 [thread overview]
Message-ID: <20180409131336.21990-2-robert.rosengren@axis.com> (raw)
In-Reply-To: <20180409131336.21990-1-robert.rosengren@axis.com>
From: Danny Smith <dannys@axis.com>
Reloading fw causes an audiable popping sound, we can avoid this
by not reloading if the samplerate is the same as before.
Signed-off-by: Danny Smith <dannys@axis.com>
Signed-off-by: Robert Rosengren <robert.rosengren@axis.com>
---
sound/soc/codecs/adau17x1.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/sound/soc/codecs/adau17x1.c b/sound/soc/codecs/adau17x1.c
index 12bf24c26818..ae41edd1c406 100644
--- a/sound/soc/codecs/adau17x1.c
+++ b/sound/soc/codecs/adau17x1.c
@@ -843,6 +843,15 @@ int adau17x1_setup_firmware(struct snd_soc_component *component,
struct adau *adau = snd_soc_component_get_drvdata(component);
struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component);
+ /* Check if sample rate is the same as before. If it is there is no
+ * point in performing the below steps as the call to
+ * sigmadsp_setup(...) will return directly when it finds the sample
+ * rate to be the same as before. By checking this we can prevent an
+ * audiable popping noise which occours when toggling DSP_RUN.
+ */
+ if (adau->sigmadsp->current_samplerate == rate)
+ return 0;
+
snd_soc_dapm_mutex_lock(dapm);
ret = regmap_read(adau->regmap, ADAU17X1_DSP_SAMPLING_RATE, &dspsr);
--
2.11.0
next prev parent reply other threads:[~2018-04-09 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 13:13 [PATCH v2 1/2] ASoC: adau17x1: Handling of DSP_RUN register during fw setup Robert Rosengren
2018-04-09 13:13 ` Robert Rosengren [this message]
2018-04-12 16:30 ` [PATCH v2 2/2] ASoC: adau17x1: Do not reload dsp-fw if samplerate has not changed Lars-Peter Clausen
2018-04-16 11:59 ` Applied "ASoC: adau17x1: Do not reload dsp-fw if samplerate has not changed" to the asoc tree Mark Brown
2018-04-12 16:30 ` [PATCH v2 1/2] ASoC: adau17x1: Handling of DSP_RUN register during fw setup Lars-Peter Clausen
2018-04-13 10:56 ` Applied "ASoC: adau17x1: Handling of DSP_RUN register during fw setup" to the asoc tree Mark Brown
2018-04-13 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409131336.21990-2-robert.rosengren@axis.com \
--to=robert.rosengren@axis.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dannys@axis.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=robertr@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).