Re: [PATCH 4/4] ASoC: tegra: i2s: Add support for more than 2 channels

From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>,
	lgirdwood@gmail.com, thierry.reding@gmail.com,
	alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH 4/4] ASoC: tegra: i2s: Add support for more than 2 channels
Date: Mon, 30 Jul 2018 11:21:45 +0100
Message-ID: <20180730102145.GG5789@sirena.org.uk> (raw)
In-Reply-To: <d81d5c3c-2b2f-308f-d98e-d39c5d5d147f@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

On Mon, Jul 30, 2018 at 10:46:14AM +0100, Jon Hunter wrote:
> On 27/07/18 13:59, Jorge Sanjuan wrote:

> > -	if (params_channels(params) != 2)
> > +	if (params_channels(params) > 8)
> >  		return -EINVAL;

> For normal I2S mode, channels should always be 2 and so it could be worth checking
> if we are using TDM mode here or not.

Yes, there's some question if a multi-channel I2S setup is going to be
all the left channels then all the right channels, have multiple data
lines in parallel (this especially common for high end applications) or
something else.  Usually it's safer to use a DSP mode for those.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]