From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
vkoul@kernel.org, broonie@kernel.org,
srinivas.kandagatla@linaro.org, jank@cadence.com,
slawomir.blauciak@intel.com,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [alsa-devel] [RFC PATCH 0/5] ASoC: SOF: Intel: SoundWire initial integration
Date: Thu, 22 Aug 2019 17:19:29 +0200 [thread overview]
Message-ID: <20190822151928.GB1200@ubuntu> (raw)
In-Reply-To: <20190821201720.17768-1-pierre-louis.bossart@linux.intel.com>
Hi Pierre,
In patch 4/5 I forgot to mention superfluous braces around dev_err()
in sdw_config_stream() and sdw_free_stream(). Otherwise for the series:
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Thanks
Guennadi
On Wed, Aug 21, 2019 at 03:17:15PM -0500, Pierre-Louis Bossart wrote:
> This RFC is the companion of the other RFC 'soundwire: intel: simplify
> DAI/PDI handling'. Our purpose at this point is to gather feedback on
> the interfaces between the Intel SOF parts and the SoundWire code.
>
> The suggested solution is a simple init/release inserted at
> probe/remove and resume/suspend, as well as two callbacks for the SOF
> driver to generate IPC configurations with the firmware. That level of
> separation completely hides the details of the SoundWire DAIs and will
> allow for 'transparent' multi-cpu DAI support, which will be handled
> in the machine driver and the soundwire DAIs.
>
> This solution was tested on IceLake and CometLake, and captures the
> feedback from SOF contributors on an initial integration that was
> deemed too complicated (and rightly so).
>
> Pierre-Louis Bossart (5):
> ASoC: SOF: IPC: dai-intel: move ALH declarations in header file
> ASoC: SOF: Intel: hda: add helper to initialize SoundWire IP
> ASoC: SOF: Intel: hda: add SoundWire IP support
> ASoC: SOF: Intel: hda: add SoundWire stream config/free callbacks
> ASoC: SOF: Intel: add support for SoundWire suspend/resume
>
> include/sound/sof/dai-intel.h | 18 ++--
> sound/soc/sof/intel/hda-dsp.c | 11 +++
> sound/soc/sof/intel/hda.c | 157 ++++++++++++++++++++++++++++++++++
> sound/soc/sof/intel/hda.h | 11 +++
> 4 files changed, 188 insertions(+), 9 deletions(-)
>
>
> base-commit: 3b3aaa017e8072b1bfddda92be296b3463d870be
> --
> 2.20.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-08-22 15:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 20:17 [RFC PATCH 0/5] ASoC: SOF: Intel: SoundWire initial integration Pierre-Louis Bossart
2019-08-21 20:17 ` [RFC PATCH 1/5] ASoC: SOF: IPC: dai-intel: move ALH declarations in header file Pierre-Louis Bossart
2019-08-21 20:17 ` [RFC PATCH 2/5] ASoC: SOF: Intel: hda: add helper to initialize SoundWire IP Pierre-Louis Bossart
2019-08-21 20:17 ` [RFC PATCH 3/5] ASoC: SOF: Intel: hda: add SoundWire IP support Pierre-Louis Bossart
2019-09-04 7:21 ` [alsa-devel] " Vinod Koul
2019-09-04 13:25 ` Pierre-Louis Bossart
2019-09-04 16:51 ` Vinod Koul
2019-09-04 17:47 ` Pierre-Louis Bossart
2019-08-21 20:17 ` [RFC PATCH 4/5] ASoC: SOF: Intel: hda: add SoundWire stream config/free callbacks Pierre-Louis Bossart
2019-08-22 7:18 ` Guennadi Liakhovetski
2019-08-22 7:23 ` Guennadi Liakhovetski
2019-08-22 13:53 ` Pierre-Louis Bossart
2019-08-22 15:11 ` Guennadi Liakhovetski
2019-09-04 7:35 ` [alsa-devel] " Vinod Koul
2019-09-04 13:31 ` Pierre-Louis Bossart
2019-09-04 16:55 ` Vinod Koul
2019-09-04 17:49 ` Pierre-Louis Bossart
2019-08-21 20:17 ` [RFC PATCH 5/5] ASoC: SOF: Intel: add support for SoundWire suspend/resume Pierre-Louis Bossart
2019-08-22 15:19 ` Guennadi Liakhovetski [this message]
2019-08-22 16:00 ` [alsa-devel] [RFC PATCH 0/5] ASoC: SOF: Intel: SoundWire initial integration Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822151928.GB1200@ubuntu \
--to=guennadi.liakhovetski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).