From: Tony Lindgren <tony@atomide.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
Tomas Novotny <tomas@novotny.cz>
Subject: Re: [alsa-devel] omap-mcbsp: TX Buffer Overflow
Date: Mon, 9 Sep 2019 09:24:07 -0700 [thread overview]
Message-ID: <20190909162407.GO52127@atomide.com> (raw)
In-Reply-To: <20190907091358.GA7166@lenoch>
* Ladislav Michl <ladis@linux-mips.org> [190907 09:14]:
> On Fri, Sep 06, 2019 at 04:51:09PM +0200, Tomas Novotny wrote:
> > Hi,
> >
> > we have AM3703 based board similar to BeagleBoard. I'm hitting this error
> > after upgrade to latest LTS 4.19.71 (upgraded from 4.1):
> >
> > omap-mcbsp 49022000.mcbsp: TX Buffer Overflow!
> >
> > This appears during or after playing of short (~2s) ding-dong wav. That error
> > exists for longer time, because handling of tx buffer overflow irq was
> > introduced in 2016: 4e85e7776eba ("ASoC: omap-mcbsp: Enable TX/RX under and
> > overflow interrupts"). I've cherry-picked it to 4.1 and I see the error there also.
> > The sound seems clear and ok to me, but we are using low quality speaker.
>
> Just FYI, for stream capture there's
> omap-mcbsp 49022000.mcbsp: RX Buffer Underflow!
>
> As far as I remember all stable kernels we have in production - 4.9.x, 4.14.x and
> 4.19.x - are affected. IGEPv2 with both DM3730 and OMAP3530 are affected
> (headless machines, CONFIG_VIDEO_OMAP3=n).
Hmm I wonder if this is still related to the SoC idling?
See commit 9834ffd1ecc3 ("ASoC: omap-mcbsp: Add PM QoS support for McBSP
to prevent glitches"), maybe something still needs to be fixed in that
area.
> And DT is probably worth updating:
> omap_hwmod: mcbsp2_sidetone using broken dt data from mcbsp
> omap_hwmod: mcbsp3_sidetone using broken dt data from mcbsp
>
> I never motivated myself to dig deeper as catured stream looks pretty normal.
These mean the devices should really have separate nodes
in the dts rather than combining multiple devices into a
single node with multiple reg entries.
The issue with combining multiple devices into a single device
is that flushing posted write with a read back to one register
range will not flush it for the other which can cause mysterious
bugs.
Regards,
Tony
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-09 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 14:51 [alsa-devel] omap-mcbsp: TX Buffer Overflow Tomas Novotny
2019-09-07 9:13 ` Ladislav Michl
2019-09-09 16:24 ` Tony Lindgren [this message]
2019-09-10 8:05 ` Tomas Novotny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909162407.GO52127@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=ladis@linux-mips.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomas@novotny.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).