From: Mark Brown <broonie@kernel.org>
To: shifu0704@thundersoft.com
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, navada@ti.com, tiwai@suse.com,
dmurphy@ti.com
Subject: Re: [alsa-devel] [PATCH] tas2770: add tas2770 smart PA dt bindings
Date: Tue, 10 Sep 2019 12:37:53 +0100 [thread overview]
Message-ID: <20190910113753.GO2036@sirena.org.uk> (raw)
In-Reply-To: <1567753564-13699-1-git-send-email-shifu0704@thundersoft.com>
[-- Attachment #1.1: Type: text/plain, Size: 316 bytes --]
On Fri, Sep 06, 2019 at 03:06:03PM +0800, shifu0704@thundersoft.com wrote:
> + - ti,left-slot: - Sets TDM RX left time slots.
> + - ti,right-slot: - Sets TDM RX right time slots.
This looks like it's duplicating things that are normally done
with the set_tdm_slot() callback. Otherwise the binding looks
good.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-10 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 7:06 [alsa-devel] [PATCH] tas2770: add tas2770 smart PA dt bindings shifu0704
2019-09-06 7:06 ` [alsa-devel] [PATCH] tas2770: add tas2770 smart PA kernel driver shifu0704
2019-09-10 12:33 ` Mark Brown
2019-09-10 13:58 ` Dan Murphy
2019-09-10 11:37 ` Mark Brown [this message]
2019-09-10 13:21 ` [alsa-devel] [PATCH] tas2770: add tas2770 smart PA dt bindings Dan Murphy
2019-09-10 13:47 ` Dan Murphy
2019-09-11 10:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910113753.GO2036@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dmurphy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=shifu0704@thundersoft.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).