From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: clemens@ladisch.de, tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: [alsa-devel] [PATCH 0/2] ALSA: firewire-tascam: fix to handle error code to read status of sampling clock
Date: Tue, 10 Sep 2019 22:51:50 +0900 [thread overview]
Message-ID: <20190910135152.29800-1-o-takashi@sakamocchi.jp> (raw)
Hi,
ALSA firewire-tascam driver has a bug not to check return value from
a call of snd_tscm_stream_get_clock() since its first commit. This
patchset fixes the bug.
In models of TASCAM FIreWire series, the status of sampling clock is
represented in 2 bytes in MSB of a certain register. These bits are
zero in intermediate state after configuring the sampling clock. This
behaviour sometimes takes ALSA PCM applications to receive error when
starting both playback/capture PCM substreams because the operation to
start one PCM substream can change the sampling clock. In this case,
next operation for another PCM substream possible fails.
This patchset adds check and retry for the above case. Although the
change is a bit intrusive for stable releases, it's required to avoid
superficial regression due to the additional error check.
Takashi Sakamoto (2):
ALSA: firewire-tascam: handle error code when getting current source
of clock
ALSA: firewire-tascam: check intermediate state of clock status and
retry
sound/firewire/tascam/tascam-pcm.c | 3 ++
sound/firewire/tascam/tascam-stream.c | 42 ++++++++++++++++++---------
2 files changed, 31 insertions(+), 14 deletions(-)
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next reply other threads:[~2019-09-10 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 13:51 Takashi Sakamoto [this message]
2019-09-10 13:51 ` [alsa-devel] [PATCH 1/2] ALSA: firewire-tascam: handle error code when getting current source of clock Takashi Sakamoto
2019-09-10 14:17 ` Takashi Iwai
2019-09-10 13:51 ` [alsa-devel] [PATCH 2/2] ALSA: firewire-tascam: check intermediate state of clock status and retry Takashi Sakamoto
2019-09-10 14:17 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910135152.29800-1-o-takashi@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).