From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org,
tiwai@suse.com, lgirdwood@gmail.com, nicoleotsuka@gmail.com,
robh+dt@kernel.org, festevam@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: fsl_mqs: Add MQS component driver
Date: Wed, 11 Sep 2019 11:12:30 +0100 [thread overview]
Message-ID: <20190911101230.GT2036@sirena.org.uk> (raw)
In-Reply-To: <08524f143c18521680b724ab98375828fc18ab2b.1568169346.git.shengjiu.wang@nxp.com>
[-- Attachment #1.1: Type: text/plain, Size: 1362 bytes --]
On Wed, Sep 11, 2019 at 10:42:39AM -0400, Shengjiu Wang wrote:
This looks good, a few minor comments below but nothing major -
it's mostly nits with the DT binding.
> --- /dev/null
> +++ b/sound/soc/fsl/fsl_mqs.c
> @@ -0,0 +1,336 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * ALSA SoC IMX MQS driver
> + *
> + * Copyright (C) 2014-2019 Freescale Semiconductor, Inc.
> + *
Please make the entire comment block a C++ comment so things look
neater.
> + /* On i.MX6sx the MQS control register is in GPR domain
> + * But in i.MX8QM/i.MX8QXP the control register is moved
> + * to its own domain.
> + */
> + if (of_device_is_compatible(np, "fsl,imx8qm-mqs"))
> + mqs_priv->use_gpr = false;
> + else
> + mqs_priv->use_gpr = true;
The GPR was listed as a required property in the binding document
but it is only needed here so the binding document should say
"required if compatible is...".
> + } else {
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + regs = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(regs))
You can use devm_platform_ioremap_resource() here.
> + mqs_priv->ipg = devm_clk_get(&pdev->dev, "core");
> + if (IS_ERR(mqs_priv->ipg)) {
> + dev_err(&pdev->dev, "failed to get the clock: %ld\n",
> + PTR_ERR(mqs_priv->ipg));
> + goto out;
> + }
The core clock wasn't listed in the bindings document.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-09-11 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 14:42 [alsa-devel] [PATCH 1/2] ASoC: fsl_mqs: add DT binding documentation Shengjiu Wang
2019-09-11 6:31 ` Christophe Leroy
2019-09-11 10:03 ` Mark Brown
2019-09-11 14:42 ` [alsa-devel] [PATCH 2/2] ASoC: fsl_mqs: Add MQS component driver Shengjiu Wang
2019-09-11 10:12 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911101230.GT2036@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).