From: Mark Brown <broonie@kernel.org>
To: shifu0704@thundersoft.com
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, navada@ti.com, tiwai@suse.com,
robh+dt@kernel.org, dmurphy@ti.com
Subject: Re: [alsa-devel] [PATCH v3] tas2770: add tas2770 smart PA kernel driver
Date: Thu, 12 Sep 2019 12:17:40 +0100 [thread overview]
Message-ID: <20190912111740.GL2036@sirena.org.uk> (raw)
In-Reply-To: <1568253638-14027-1-git-send-email-shifu0704@thundersoft.com>
[-- Attachment #1.1: Type: text/plain, Size: 1287 bytes --]
On Thu, Sep 12, 2019 at 10:00:38AM +0800, shifu0704@thundersoft.com wrote:
> From: Frank Shi <shifu0704@thundersoft.com>
>
> add tas2770 smart PA kernel driver
>
> Signed-off-by: Frank Shi <shifu0704@thundersoft.com>
> ---
> sound/soc/codecs/Kconfig | 5 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/tas2770.c | 952 +++++++++++++++++++++++++++++++++++++++++++++
> sound/soc/codecs/tas2770.h | 166 ++++++++
We've lost the device tree binding patch from this version?
> +static int tas2770_regmap_read(struct tas2770_priv *tas2770,
> + unsigned int reg, unsigned int *value)
> +{
> + int result = 0;
> + int retry_count = TAS2770_I2C_RETRY_COUNT;
> +
> + while (retry_count--) {
> + result = snd_soc_component_read(tas2770->component, reg,
> + value);
> + if (!result)
> + break;
> +
> + msleep(20);
> + }
> + if (!retry_count)
> + return -ETIMEDOUT;
> +
> + return 0;
> +}
It looks like we still have this code for what appears to be
handling the device randomly resetting underneath the driver.
Please, as I've said on both prior versions, split this out into
a separate patch to ease review and explain why this is required.
Start off with a simple driver which looks like normal drivers,
add this stuff later.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-09-12 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 2:00 [alsa-devel] [PATCH v3] tas2770: add tas2770 smart PA kernel driver shifu0704
2019-09-12 11:17 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912111740.GL2036@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dmurphy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=robh+dt@kernel.org \
--cc=shifu0704@thundersoft.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).