From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C71CC4CEC6 for ; Thu, 12 Sep 2019 23:55:09 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA645208E4 for ; Thu, 12 Sep 2019 23:55:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="l4s2JoCw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pXYgnB8v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA645208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 935DD166B; Fri, 13 Sep 2019 01:54:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 935DD166B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568332506; bh=QW/aXTkUgFlyV3962wSE88UFrQY9ySxb6CQOdhNIFEU=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=l4s2JoCw3M5gxXQhrXK5SE/vX5GyE5oCMF8ajQHYZmTXjUDUkHJGN3p9OtL7c02Sa q99q7olX0O+PYbShV5GpnfQ2TZf1guhl6OU2hFvPdPXBb4bc1oIccb3uY17cIv+Liu TiiKYDLidF5Z8YfDvb8YEAhHVm49kvDcwXRxljqI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2A286F80143; Fri, 13 Sep 2019 01:54:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B8DA6F801ED; Fri, 13 Sep 2019 01:54:14 +0200 (CEST) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 13A44F801ED for ; Fri, 13 Sep 2019 01:54:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 13A44F801ED Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pXYgnB8v" Received: by mail-pl1-x644.google.com with SMTP id x3so12429413plr.12 for ; Thu, 12 Sep 2019 16:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=epB8CH0IOuw5TsX1fUGnwbGIVGe9v0LlpjCzGxP60TQ=; b=pXYgnB8v9vuvLFdz1UIqGnHVmsaO3b0KOiGh94bEt4QtpedVNNzipx+iIyYTwI9Obp XO2uCQ95ITV+w4RvV4PyxkNHy+kpiezsIVRJv8PAJogfMw2vTb9xDyWb7D3JhTT3iT0B jvM76OsIptNMydQYZA9B5ztqtWw1qSuDVXvMIbL6N0t1jesIi2xmx2Yha5x/RhMVF3KB BgW/7PYc2HrGuo52dVHBTSxe80oMM70A8aPVWGjpJDye5OCJLyXU+7hak0kxTsR47VwG KCbqs5X+Aq8SymUGWQCh/dFK4DIJ4Lz0VTuEDEPWhLWLNLekup1nd+lkC13UMqbwrmqA +NRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=epB8CH0IOuw5TsX1fUGnwbGIVGe9v0LlpjCzGxP60TQ=; b=XQocbn3iefro++VowLTlc8l36Le+5lQNPq5mt1oBSYzKEYfUF2E34/fRuyZm10aYA9 f8RTSvJ1wyxlgpR7YY51zCRnqYUOmzLqBkOVQelWIX10vs2jSdQBD4RJgF81Ki4KMGrT v7bNgV+1nlDIv/p20Ut4rS4pSYphF7I4QGhRZr4izSJ4pQrDf7agU2IBP9AX5yT7MFOi mX5RMKL8y/0wnsms/dK+EqpSqaWgu0Pwi47AYuYNumINSwmwAf4czNHY1wD3P8XYhw1e RsqsGOV18rlHrxREL9W6uAh1pwVf4iVtxNewJEHzPAFzUQVsN+I+s5r+gz0PemZN1Uoj BQeg== X-Gm-Message-State: APjAAAUFIV5l7DTKN0TOUJqj+caMzv2FJcVcvDxdEOBk868qIiKtifpU OqbW2DesgOmfwUAjWdt2X/8= X-Google-Smtp-Source: APXvYqwzde8vJPDro3KBWaFAJc6Uo/3ggP569vDzVpDisDugeNgt80nBA+MCUnil+1LZlDzNpLDpvA== X-Received: by 2002:a17:902:9d90:: with SMTP id c16mr34653633plq.12.1568332450067; Thu, 12 Sep 2019 16:54:10 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id a20sm24584085pfo.33.2019.09.12.16.54.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Sep 2019 16:54:09 -0700 (PDT) Date: Thu, 12 Sep 2019 16:53:48 -0700 From: Nicolin Chen To: Mark Brown Message-ID: <20190912235348.GE24937@Asurada-Nvidia.nvidia.com> References: <2b6e028ca27b8569da4ab7868d7b90ff8c3225d0.1568025083.git.shengjiu.wang@nxp.com> <20190910015212.GA16760@Asurada-Nvidia.nvidia.com> <20190911110807.GB2036@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190911110807.GB2036@sirena.org.uk> User-Agent: Mutt/1.9.4 (2018-02-28) Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, Shengjiu Wang , tiwai@suse.com, lgirdwood@gmail.com, festevam@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 3/3] ASoC: fsl_asrc: Fix error with S24_3LE format bitstream in i.MX8 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Sep 11, 2019 at 12:08:07PM +0100, Mark Brown wrote: > On Mon, Sep 09, 2019 at 06:52:13PM -0700, Nicolin Chen wrote: > > > And a quick feeling is that below code is mostly identical to what > > is in the soc-generic-dmaengine-pcm.c file. So I'm wondering if we > > could abstract a helper function somewhere in the ASoC core: Mark? > > That's roughly what sound/core/pcm_dmaengine.c is doing - > possibly we should move more stuff into there. It looks like a right place to me. Thank you! _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel