From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: [alsa-devel] [PATCH 10/13] ASoC: SOF: Intel: hda: fix warnings during FW load
Date: Fri, 27 Sep 2019 15:05:35 -0500 [thread overview]
Message-ID: <20190927200538.660-11-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20190927200538.660-1-pierre-louis.bossart@linux.intel.com>
From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
The "snd_pcm_substream" handle was not initialized properly
in hda-loader.c for firmware load.
When the HDA DMAs were used to load the firmware,
the interrupts related to firmware load also triggered
calls to snd_sof_pcm_period_elapsed() on a non-existent ALSA
PCM stream.
This caused runtime kernel warnings from
pcm_lib.c:snd_pcm_period_elapsed().
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/sof/intel/hda-loader.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/sof/intel/hda-loader.c b/sound/soc/sof/intel/hda-loader.c
index 6427f0b3a2f1..65c2af3fcaab 100644
--- a/sound/soc/sof/intel/hda-loader.c
+++ b/sound/soc/sof/intel/hda-loader.c
@@ -44,6 +44,7 @@ static int cl_stream_prepare(struct snd_sof_dev *sdev, unsigned int format,
return -ENODEV;
}
hstream = &dsp_stream->hstream;
+ hstream->substream = NULL;
/* allocate DMA buffer */
ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV_SG, &pci->dev, size, dmab);
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-27 20:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 20:05 [alsa-devel] [PATCH 00/13] ASoC: SOF: fixes and improvements Pierre-Louis Bossart
2019-09-27 20:05 ` [alsa-devel] [PATCH 01/13] ASoC: SOF: loader: fix kernel oops on firmware boot failure Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: loader: fix kernel oops on firmware boot failure" to the asoc tree Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 02/13] ASoC: SOF: topology: fix parse fail issue for byte/bool tuple types Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: topology: fix parse fail issue for byte/bool tuple types" to the asoc tree Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 03/13] ASoC: SOF: trace: move to opt-in with Kconfig and module parameter Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: trace: move to opt-in with Kconfig and module parameter" to the asoc tree Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 04/13] ASoC: SOF: ipc: retain DSP context after FW exception Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: ipc: retain DSP context after FW exception." to the asoc tree Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 05/13] ASoC: SOF: pcm: fix resource leak in hw_free Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: pcm: fix resource leak in hw_free" to the asoc tree Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 06/13] ASoC: SOF: pcm: harden PCM STOP sequence Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: pcm: harden PCM STOP sequence" to the asoc tree Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 07/13] ASoC: SOF: core: check for mandatory fw_ready op during SOF probe Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: core: check for mandatory fw_ready op during SOF probe" to the asoc tree Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 08/13] ASoC: SOF: ipc: introduce no_stream_position in sof_ipc_stream_params struct Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: ipc: introduce no_stream_position in sof_ipc_stream_params struct" to the asoc tree Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 09/13] ASoC: SOF: Intel: hda: fix reset of host_period_bytes Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: fix reset of host_period_bytes" to the asoc tree Mark Brown
2019-09-27 20:05 ` Pierre-Louis Bossart [this message]
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: fix warnings during FW load" " Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 11/13] ASoC: SOF: Intel: initialise and verify FW crash dump data Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: Intel: initialise and verify FW crash dump data." to the asoc tree Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 12/13] ASoC: SOF: Intel: Add context data to any IPC timeout Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: Intel: Add context data to any IPC timeout." to the asoc tree Mark Brown
2019-09-27 20:05 ` [alsa-devel] [PATCH 13/13] ASoC: SOF: Intel: hda: Disable DMI L1 entry during capture Pierre-Louis Bossart
2019-10-01 17:56 ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: Disable DMI L1 entry during capture" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927200538.660-11-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).