From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD0DECE58D for ; Wed, 9 Oct 2019 14:16:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F4062218DE for ; Wed, 9 Oct 2019 14:16:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Xe3Ja7/A"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="cVvyCmy+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F4062218DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DA15B15E0; Wed, 9 Oct 2019 16:15:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DA15B15E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1570630580; bh=aY1kzboVe78xPXhjcmRhBdopKPNuo2SGQ3kqbDmuG+Q=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Xe3Ja7/Aw/9/XywX0pIvBn+oNJ4rWiW3a61rqDiSauaYJDspIfvzjcL77cMzRHez5 x+S2gCo3qVft4Edr9QY6kDu49iUAcfCvfMWgKtVFf5Mh9oGRTj5c/YikZhTSkmPc0a +sdddJozDg76ndr09MyuawzQZkyXzJqTp1QiKhVE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6B472F802BD; Wed, 9 Oct 2019 16:15:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E4E60F802BE; Wed, 9 Oct 2019 16:15:28 +0200 (CEST) Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D0886F800AE for ; Wed, 9 Oct 2019 16:15:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D0886F800AE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="cVvyCmy+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=POxETTBPmCjnYU0uMGoBV2RzCASmpLWvSLKtWWIJZwk=; b=cVvyCmy+tEAk+rcYenhPDEhdU TP4QTzDW5yls+FqwUrta/d0bE/AsGBuRSMeVUGfxtlhT75zq+4Yau6o36i3YvTqBuXVozNLMpse9z iMkMEtGbjZKwGzb2BCoC3YUmwD5iJsfPL5lRL3tD3mKzQTqJyISuq0r9CtnaItxDpGR9k=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iICkM-0004x2-TE; Wed, 09 Oct 2019 14:15:22 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 67E6B2741DF9; Wed, 9 Oct 2019 15:15:22 +0100 (BST) Date: Wed, 9 Oct 2019 15:15:22 +0100 From: Mark Brown To: Shuming =?utf-8?B?W+iMg+abuOmKmF0=?= Message-ID: <20191009141522.GD3929@sirena.co.uk> References: MIME-Version: 1.0 In-Reply-To: X-Cookie: Every path has its puddle. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Oder Chiou , Jack Yu , "alsa-devel@alsa-project.org" , "lars@metafoo.de" , "lgirdwood@gmail.com" , Derek =?utf-8?B?W+aWueW+t+e+qV0=?= , "sathya.prakash.m.r@intel.com" , "Flove\(HsinFu\)" Subject: Re: [alsa-devel] [PATCH RESEND] ASoC: rt1011: set tx/rx slots from tx/rx_mask in TDM case X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5948272256627224798==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============5948272256627224798== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IDYEmSnFhs3mNXr+" Content-Disposition: inline --IDYEmSnFhs3mNXr+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 08, 2019 at 09:32:05AM +0000, Shuming [=E8=8C=83=E6=9B=B8=E9=8A= =98] wrote: > + if (first_bit =3D=3D 0 || first_bit =3D=3D 2 || > + first_bit =3D=3D 4 || first_bit =3D=3D 6) { > + } else { > + } This would be more idiomatically written as a switch statement, as would the equivalent stuff on the TX side. --IDYEmSnFhs3mNXr+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2d63kACgkQJNaLcl1U h9CdUwf/ZlJrXiP9kQBlJRSWU0taqVFsGDEHukkbW2JnmRPWzLfXDjznn19A2qiw J1KrVFrk2KzftEQqUuhChKkW8wGiSgMUj3oam3aQxn2xVgQ7Oa9/simpt7yJzymJ PfGowaeit1xzXY/g0/28rcbkgrpy3YPwCYmfTMw2uDt2WSuFwIXw8biAJ8j+p/ec n4Ny7cQz2Gt/ApL8z7adu+NeEIC4bY8HDNPHO7d+zE+TDitRtwP/nmVzt9V49u8j L1Y4Bw/zyz0LlTZo4fdFo7SKLlRgRer2a1y25MMaj46gbmZmJuGiMUulxplQ5ig0 TUQAtOoaaD8brvfcV9k5psitdSGHFQ== =1q/q -----END PGP SIGNATURE----- --IDYEmSnFhs3mNXr+-- --===============5948272256627224798== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============5948272256627224798==--