From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, bgoswami@codeaurora.org,
spapothi@codeaurora.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, vkoul@kernel.org
Subject: Re: [alsa-devel] [RFC PATCH] ASoC: soc-dapm: Invalidate DAPM path during dapm addition of routes
Date: Wed, 9 Oct 2019 17:59:53 +0100 [thread overview]
Message-ID: <20191009165953.GM2036@sirena.org.uk> (raw)
In-Reply-To: <20191009102127.7860-1-srinivas.kandagatla@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 965 bytes --]
On Wed, Oct 09, 2019 at 11:21:27AM +0100, Srinivas Kandagatla wrote:
> From: Sudheer Papothi <spapothi@codeaurora.org>
>
> During sound card registration, dapm adds routes of
> codec and other component paths, but the invalidation of
> the widgets in these paths will happen only when the
> sound card is instantiated. As these routes are added
The whole point with this check is that as you say we're
validating everything as we instantiate the card, not piecemeal
while the map is partially constructed. Doing that is wasteful
and noisy.
> before sound card instantiation, these widgets are
> not invalidated until a playback or recording usecase
> is started.
You said yourself that we sync everything when the card is
instantiated. Not on first capture or record, when the card is
instantiated. If for some reason there is some problem with that
on your system please fix that, don't add a bodge somewhere else
to mask the problem.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-10-09 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 10:21 [alsa-devel] [RFC PATCH] ASoC: soc-dapm: Invalidate DAPM path during dapm addition of routes Srinivas Kandagatla
2019-10-09 16:59 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009165953.GM2036@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spapothi@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).