On Thu, Oct 10, 2019 at 09:42:33AM +0200, Nuno Sá wrote: > + /* power on */ > + ret = regulator_enable(st->iovdd); > + if (ret) > + return ret; > + > + /* there's no timing constraints before enabling dvdd */ > + ret = regulator_enable(st->dvdd); > + if (ret) { > + regulator_disable(st->iovdd); > + return ret; > + } You could use regulator_bulk_enable() here (and similarly on disable) but it doesn't fundamentally matter - they do guarantee that they'll do things in sequence, though they don't wait for the ramp to complete before kicking off the next enable in the sequence which can be an issue for some hardware.