From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC580C4360C for ; Thu, 10 Oct 2019 14:06:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50BAD206A1 for ; Thu, 10 Oct 2019 14:06:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="IbYt9oSl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="AVWXSHoe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50BAD206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 89EE71654; Thu, 10 Oct 2019 16:05:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 89EE71654 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1570716369; bh=wHwX7roALlG5dHlugBcp2wroCNVE/sFjF3dB88EVIHQ=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IbYt9oSlz/QX8vyJMPsQymY4tKRYU/AI+5JAkiTSxNvaQ/NjrB08IjH8/jsemf7bw EeK7r9AliEf26vavMDXR5ZR8oa4umgd5PrYhHK/g0hEyGZDe8nQDfDEZN9UKKNljhV 9X4O3Hsgo5Vlf0LSvxzIMVA653XimCaRKOi+vUzg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 15A0AF80322; Thu, 10 Oct 2019 16:05:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7B678F8038F; Thu, 10 Oct 2019 16:05:17 +0200 (CEST) Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 08EADF80113 for ; Thu, 10 Oct 2019 16:05:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 08EADF80113 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="AVWXSHoe" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YKb2E0bqtC+1TS6bbf5/9WOYFCNWex11PfY1IyHGgs0=; b=AVWXSHoeV5dXwKMHtFgapdpHe luf83G9y5Cvk+3H6TVEWgYuBPnHWJKjh7dQq0Ubl6R+3OjeeZq/SnQGXaeQBwow27JLd3OinXxuhW NaHgIzrRmwUdGbGojf/VkSpa/I0rbQPcSHLi3Kb7DDobrloTpriQK1++chVZZl7oT4+qY=; Received: from fw-tnat-cam3.arm.com ([217.140.106.51] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iIZ45-0001Vb-9c; Thu, 10 Oct 2019 14:05:13 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id DC38CD0003A; Thu, 10 Oct 2019 15:05:12 +0100 (BST) Date: Thu, 10 Oct 2019 15:05:12 +0100 From: Mark Brown To: Nuno =?iso-8859-1?Q?S=E1?= Message-ID: <20191010140512.GT2036@sirena.org.uk> References: <20191010074234.7344-1-nuno.sa@analog.com> MIME-Version: 1.0 In-Reply-To: <20191010074234.7344-1-nuno.sa@analog.com> X-Cookie: Be careful! UGLY strikes 9 out of 10! User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Lars-Peter Clausen , Takashi Iwai , Liam Girdwood , Rob Herring Subject: Re: [alsa-devel] [PATCH v3 1/2] ASOC: Add ADAU7118 8 Channel PDM-to-I2S/TDM Converter driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0006631323230166991==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============0006631323230166991== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZYwTRRUThkGj9JQ7" Content-Disposition: inline --ZYwTRRUThkGj9JQ7 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 10, 2019 at 09:42:33AM +0200, Nuno S=E1 wrote: > + /* power on */ > + ret =3D regulator_enable(st->iovdd); > + if (ret) > + return ret; > + > + /* there's no timing constraints before enabling dvdd */ > + ret =3D regulator_enable(st->dvdd); > + if (ret) { > + regulator_disable(st->iovdd); > + return ret; > + } You could use regulator_bulk_enable() here (and similarly on disable) but it doesn't fundamentally matter - they do guarantee that they'll do things in sequence, though they don't wait for the ramp to complete before kicking off the next enable in the sequence which can be an issue for some hardware. --ZYwTRRUThkGj9JQ7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2fOpUACgkQJNaLcl1U h9BEPwf/VxMhiR0z6PYlab1hBh6JMo2K1WIXb2S3zahILtM5SXxYMmwRh16GuG0o pIrwnxc5hMD4+bqp6vYu9QaISbKB8UoBsAr+SU5b/eHsba3r0Jbl/wNdTdbgCVus ZCYLHYtnWZrx9okSggQ9viUDkqls7dLCPMfu/+qV5NiDAasZJZUIEjkaUdfAhYwS z0yrot94R5p3QdNEI5ds7y5ZuKWGDEcWJNU3PekJ+putlZyUF8qa9/nV+/uZigQ/ hH+oMbQGEg9pgx/neQN2VxC4hIXtXcaDMT4WuEVt2HjWCK2xcFrauNzAg7HkdV0z EkVGgsiWwDQG59xutrTflWxmmQCOtw== =S+PA -----END PGP SIGNATURE----- --ZYwTRRUThkGj9JQ7-- --===============0006631323230166991== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============0006631323230166991==--