* [alsa-devel] [PATCH] alsactl: avoid needless wakeups in monitor loop.
@ 2019-10-15 4:38 Zev Weiss
2020-04-11 22:51 ` Zev Weiss
2020-04-12 2:19 ` Takashi Sakamoto
0 siblings, 2 replies; 4+ messages in thread
From: Zev Weiss @ 2019-10-15 4:38 UTC (permalink / raw)
To: alsa-devel; +Cc: Zev Weiss
The timeout wasn't really being used for anything; disabling it should
reduce idle energy consumption slightly.
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
---
alsactl/monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/alsactl/monitor.c b/alsactl/monitor.c
index 6b090e4f5c92..6d9328d899a4 100644
--- a/alsactl/monitor.c
+++ b/alsactl/monitor.c
@@ -340,7 +340,7 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs,
int count;
int i;
- count = epoll_wait(epfd, epev, max_ev_count, 200);
+ count = epoll_wait(epfd, epev, max_ev_count, -1);
if (count < 0) {
err = count;
break;
--
2.23.0
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] alsactl: avoid needless wakeups in monitor loop.
2019-10-15 4:38 [alsa-devel] [PATCH] alsactl: avoid needless wakeups in monitor loop Zev Weiss
@ 2020-04-11 22:51 ` Zev Weiss
2020-04-12 2:19 ` Takashi Sakamoto
1 sibling, 0 replies; 4+ messages in thread
From: Zev Weiss @ 2020-04-11 22:51 UTC (permalink / raw)
To: alsa-devel
Ping -- it's been a while since I sent this and
https://mailman.alsa-project.org/pipermail/alsa-devel/2019-October/156866.html,
never saw any response though. Any problems with these patches?
Thanks,
Zev Weiss
On Mon, Oct 14, 2019 at 11:38:02PM CDT, Zev Weiss wrote:
>The timeout wasn't really being used for anything; disabling it should
>reduce idle energy consumption slightly.
>
>Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
>---
> alsactl/monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/alsactl/monitor.c b/alsactl/monitor.c
>index 6b090e4f5c92..6d9328d899a4 100644
>--- a/alsactl/monitor.c
>+++ b/alsactl/monitor.c
>@@ -340,7 +340,7 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs,
> int count;
> int i;
>
>- count = epoll_wait(epfd, epev, max_ev_count, 200);
>+ count = epoll_wait(epfd, epev, max_ev_count, -1);
> if (count < 0) {
> err = count;
> break;
>--
>2.23.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] alsactl: avoid needless wakeups in monitor loop.
2019-10-15 4:38 [alsa-devel] [PATCH] alsactl: avoid needless wakeups in monitor loop Zev Weiss
2020-04-11 22:51 ` Zev Weiss
@ 2020-04-12 2:19 ` Takashi Sakamoto
2020-04-14 13:24 ` Jaroslav Kysela
1 sibling, 1 reply; 4+ messages in thread
From: Takashi Sakamoto @ 2020-04-12 2:19 UTC (permalink / raw)
To: Zev Weiss; +Cc: alsa-devel
Hi,
On Mon, Oct 14, 2019 at 11:38:02PM -0500, Zev Weiss wrote:
> The timeout wasn't really being used for anything; disabling it should
> reduce idle energy consumption slightly.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
> alsactl/monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I overlooked it as well... It looks good to me.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/alsactl/monitor.c b/alsactl/monitor.c
> index 6b090e4f5c92..6d9328d899a4 100644
> --- a/alsactl/monitor.c
> +++ b/alsactl/monitor.c
> @@ -340,7 +340,7 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs,
> int count;
> int i;
>
> - count = epoll_wait(epfd, epev, max_ev_count, 200);
> + count = epoll_wait(epfd, epev, max_ev_count, -1);
> if (count < 0) {
> err = count;
> break;
> --
> 2.23.0
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] alsactl: avoid needless wakeups in monitor loop.
2020-04-12 2:19 ` Takashi Sakamoto
@ 2020-04-14 13:24 ` Jaroslav Kysela
0 siblings, 0 replies; 4+ messages in thread
From: Jaroslav Kysela @ 2020-04-14 13:24 UTC (permalink / raw)
To: Zev Weiss, alsa-devel, Takashi Sakamoto
Dne 12. 04. 20 v 4:19 Takashi Sakamoto napsal(a):
> Hi,
>
> On Mon, Oct 14, 2019 at 11:38:02PM -0500, Zev Weiss wrote:
>> The timeout wasn't really being used for anything; disabling it should
>> reduce idle energy consumption slightly.
>>
>> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
>> ---
>> alsactl/monitor.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I overlooked it as well... It looks good to me.
>
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied. Thanks.
Jaroslav
>
>> diff --git a/alsactl/monitor.c b/alsactl/monitor.c
>> index 6b090e4f5c92..6d9328d899a4 100644
>> --- a/alsactl/monitor.c
>> +++ b/alsactl/monitor.c
>> @@ -340,7 +340,7 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs,
>> int count;
>> int i;
>>
>> - count = epoll_wait(epfd, epev, max_ev_count, 200);
>> + count = epoll_wait(epfd, epev, max_ev_count, -1);
>> if (count < 0) {
>> err = count;
>> break;
>> --
>> 2.23.0
>
> Regards
>
> Takashi Sakamoto
>
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-14 13:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 4:38 [alsa-devel] [PATCH] alsactl: avoid needless wakeups in monitor loop Zev Weiss
2020-04-11 22:51 ` Zev Weiss
2020-04-12 2:19 ` Takashi Sakamoto
2020-04-14 13:24 ` Jaroslav Kysela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).