From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Keqiao Zhang <keqiao.zhang@intel.com>,
broonie@kernel.org, Keyon Jie <yang.jie@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [alsa-devel] [PATCH 1/3] ASoC: SOF: topology: fix missing NULL pointer check
Date: Fri, 1 Nov 2019 12:09:14 -0500 [thread overview]
Message-ID: <20191101170916.26517-2-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20191101170916.26517-1-pierre-louis.bossart@linux.intel.com>
From: Keyon Jie <yang.jie@linux.intel.com>
Add check to avoid possible NULL pointer dereference issue.
This issue was reported by static analysis tools, we didn't face this
issue but we can't rule it out either as a false positive.
Reported-by: Keqiao Zhang <keqiao.zhang@intel.com>
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/sof/topology.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index e0e2ae734632..d74acb828873 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -150,6 +150,11 @@ static int sof_keyword_dapm_event(struct snd_soc_dapm_widget *w,
/* get runtime PCM params using widget's stream name */
spcm = snd_sof_find_spcm_name(sdev, swidget->widget->sname);
+ if (!spcm) {
+ dev_err(sdev->dev, "error: cannot find PCM for %s\n",
+ swidget->widget->name);
+ return -EINVAL;
+ }
/* process events */
switch (event) {
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-01 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 17:09 [alsa-devel] [PATCH 0/3] ASoC: SOF: Intel: improvements for S0ix support Pierre-Louis Bossart
2019-11-01 17:09 ` Pierre-Louis Bossart [this message]
2019-11-08 12:20 ` [alsa-devel] Applied "ASoC: SOF: topology: fix missing NULL pointer check" to the asoc tree Mark Brown
2019-11-01 17:09 ` [alsa-devel] [PATCH 2/3] ASoC: SOF: Intel: hda: set L1SEN on S0ix suspend Pierre-Louis Bossart
2019-11-08 12:20 ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: set L1SEN on S0ix suspend" to the asoc tree Mark Brown
2019-11-01 17:09 ` [alsa-devel] [PATCH 3/3] ASoC: SOF: Intel: hda: Simplify the hda_dsp_wait_d0i3c_done() function Pierre-Louis Bossart
2019-11-04 13:27 ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: Simplify the hda_dsp_wait_d0i3c_done() function" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101170916.26517-2-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=keqiao.zhang@intel.com \
--cc=tiwai@suse.de \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).