From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDF23C432C3 for ; Fri, 15 Nov 2019 13:38:03 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA7C220732 for ; Fri, 15 Nov 2019 13:38:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="mgfWtYG4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="exIVUUp5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA7C220732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B5BE51614; Fri, 15 Nov 2019 14:37:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B5BE51614 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1573825080; bh=g7HPBKt5ETPO8rX4bNbdwkhYztuuO4sapS8JTeXJYVM=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mgfWtYG40U87Vlx2YylRud8zRJjRgSMQZ4eDxb/Gmp9ds7NyT0SBjL2PjVwXk437L 1F6Qw2XoBmOoAXbOHbUHat/yIvUxkwTbPkMB/hg30D2dyiRYi/HAsanJAuHPyu+J37 OeYDuZSyyESMCZc/8Zl9X+54S1xvgcSUgOgmOHF8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2F1B5F800CC; Fri, 15 Nov 2019 14:37:10 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AE756F80104; Fri, 15 Nov 2019 14:37:08 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 34C62F800CC for ; Fri, 15 Nov 2019 14:37:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 34C62F800CC Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="exIVUUp5" Received: from localhost (unknown [122.181.197.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E30EC20728; Fri, 15 Nov 2019 13:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573825022; bh=xw6+YS+K/aX6p3C3mvtL28AvnVECOYE38j0p3cjI+i4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=exIVUUp5a2Q2YN9kc/gsxvHncmC3Ty8P1XudP4oreOB/6MqS4o8V6SYYyUf+zXvaz a4QhGJ8J9jUJ4GjjizqVUdg3vNUmN7BJ58B61qzY0oEX3f5CxKYQX1b25HsZ8dIqpL G8I0vRA1AUrD7KMckbe7o/4eM/xzNtNvx+m/nETo= Date: Fri, 15 Nov 2019 19:06:57 +0530 From: Vinod Koul To: Takashi Iwai Message-ID: <20191115133657.GA6762@vkoul-mobl> References: <20191115102705.649976-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, Banajit Goswami , Liam Girdwood , linux-arm-msm@vger.kernel.org, Patrick Lai , Takashi Iwai , Mark Brown , Bjorn Andersson , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [RFC PATCH 0/3] ALSA: compress: Add support for FLAC X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 15-11-19, 14:21, Takashi Iwai wrote: > On Fri, 15 Nov 2019 11:27:02 +0100, > Vinod Koul wrote: > > > > The current design of sending codec parameters assumes that decoders > > will have parsers so they can parse the encoded stream for parameters > > and configure the decoder. > > > > But this assumption may not be universally true and we know some DSPs > > which do not contain the parsers so additional parameters are required > > to be passed. > > > > So add these parameters starting with FLAC decoder. The size of > > snd_codec_options is still 120 bytes after this change (due to this > > being a union) > > > > I think we should also bump the (minor) version if this proposal is > > acceptable so the userspace can check and populate flac specific structure. > > > > Along, with the core header change, patches are added to support FLAC > > in Qualcomm drivers. This was tested on 96boards db845c > > > > Srinivas Kandagatla (1): > > ASoC: qcom: q6asm: add support to flac config > > > > Vinod Koul (2): > > ALSA: compress: add flac decoder params > > ASoC: qcom: q6asm-dai: add support to flac decoder > > Feel free to take my ACK for ALSA core part: > Acked-by: Takashi Iwai Thanks Takashi, should we bump the version for the header to check for. Btw I plan to add other decoders required as well. I have mp3 working without any additional params but rest need additional info Thanks -- ~Vinod _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel