alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	KCHSU0@nuvoton.com, robh+dt@kernel.org, kernel@pengutronix.de,
	thomas.fehrenbacher@siedle.de
Subject: Re: [alsa-devel] [PATCH 3/3] ASoC: nau8810: add aux input control, available on NAU8812
Date: Fri, 15 Nov 2019 16:12:10 +0000	[thread overview]
Message-ID: <20191115161210.GB4210@sirena.co.uk> (raw)
In-Reply-To: <20191115160819.15557-4-m.felsch@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 387 bytes --]

On Fri, Nov 15, 2019 at 05:08:19PM +0100, Marco Felsch wrote:

> This commit adds the support to control the aux-port on the nau8812
> devices. We don't need to differentiate the aux-port registers since
> those bitfields are set to '0' on the nau8810 devices [1,2].

It'd still be better to only register these controls if the device isn't
a nau8812 so that userspace doesn't see them.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-11-15 16:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 16:08 [alsa-devel] [PATCH 0/3] Add NAU8812 support Marco Felsch
2019-11-15 16:08 ` [alsa-devel] [PATCH 1/3] dt-bindings: ASoC: add nau8812 documentation Marco Felsch
2019-12-03 19:27   ` Rob Herring
2019-11-15 16:08 ` [alsa-devel] [PATCH 2/3] ASoC: nau8810: add support for nau8812 Marco Felsch
2019-11-15 16:08 ` [alsa-devel] [PATCH 3/3] ASoC: nau8810: add aux input control, available on NAU8812 Marco Felsch
2019-11-15 16:12   ` Mark Brown [this message]
2019-11-15 16:20     ` Marco Felsch
2019-11-15 17:14       ` Mark Brown
2019-11-16  1:43   ` AS50 KCHsu0
2019-11-18  6:46     ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115161210.GB4210@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=KCHSU0@nuvoton.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=m.felsch@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=thomas.fehrenbacher@siedle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).