From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C84C43215 for ; Wed, 20 Nov 2019 11:14:42 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 964D622445 for ; Wed, 20 Nov 2019 11:14:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="j8N6iNQ/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="skdJ1UEH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 964D622445 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EB5BB16F6; Wed, 20 Nov 2019 12:13:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EB5BB16F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1574248480; bh=sJY5+n7pFBnOc49HfXGU69R6fps5crqfHHE+D3rCOXI=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j8N6iNQ/iM0kQ03d7I7usIie/VrxAGrT/gYl6MZ+ct7rKS2W3bKL0dCVX5x/UN2vT JCazuIJCWyAN72HcMEDe8ruymx3+8SOXLrmAmjdu2nvWP0QpBuonzN4zDlyTGHP6Li ClRiW+Z9TuNis0nLlku3wRlA+JfX0im2lmFZRYlY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9DAAAF80277; Wed, 20 Nov 2019 12:02:46 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B1538F80137; Tue, 19 Nov 2019 12:10:20 +0100 (CET) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2369CF80119 for ; Tue, 19 Nov 2019 12:10:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2369CF80119 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="skdJ1UEH" Received: by mail-wm1-x344.google.com with SMTP id c22so3074953wmd.1 for ; Tue, 19 Nov 2019 03:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NYWeXLuQGLvOPwK8pHNuzurveHjA/E4XL3deYT2CQ6Q=; b=skdJ1UEHu5PJl89Mkk9VRRqLagIUdwLLzIvfE7qxc79DduSNiquwoFXzoJXVUbZ9zw g1cNgucakgJrNBfc9PtJPQUQH7hiPIbQNdvm4HfPAxaPqEE5yDoU/Fm0WZrr770x6z9Z 1mV4N6EIFIO+H5heFTgopWe3ElCwZHNDP6TrB6ZxXDF+BVJoJCgzBj9WZ81yUaCLfyGK QBfOV9xXA4+nU1SmqoIng5FZDcMYQif9wRQNWBuakBreDAgwkdsGdC6lPo7bjUeRutEb FqwSvcrmf/LrgaSpoIWvYSkunbCfPVklaj+EQbJw7jUcxpmgoRV0aJoU4yUuzBudNnyu 7iYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=NYWeXLuQGLvOPwK8pHNuzurveHjA/E4XL3deYT2CQ6Q=; b=XX+50GJthM8hAjmYFkdKIUUawUCU83CGMyREu4rwLYwk3z9+IO4EmtwNmnZnAY/cO5 EXY0G6jJ+TCYvVsUG0WMEDi0ZQg97ywdIMI8pWv896YaaTMNfAzSVc6X4KtAOrTQSM+Q f7XHOKtEa2FS3JvVZfBKKAmpYNd/xbhUNSnMcfEfINGmyQwKjaY5aPkyjORmT0WWy3V7 rmlFhdDygq6jEPHY5fzWjB1ZIETwVpjP1TU8yf/ciC7ENt+BDUFWgs6j1Jr3KgBycFYG 4aB/3pD7lI3bBQTNzUImX68nN7o4FIgXdabCIdmNmNxA8q+OjdRK/QCig44ZbEHgBAye rlOA== X-Gm-Message-State: APjAAAW9O/UOEk0g0U/xiIRKwsOxlf07ziiDHOYy+sQJ21aDwX1pM9sk Bpnn6MED9NdHYyIr2Tw4v2g= X-Google-Smtp-Source: APXvYqxkMDs2asP+vgJXKZTaN6ik3+6S/o6ZGiHDU8XukZ5zzOg6DqoFabjwqzDackICD1Kv7aubiw== X-Received: by 2002:a7b:cb4a:: with SMTP id v10mr4628412wmj.106.1574161816817; Tue, 19 Nov 2019 03:10:16 -0800 (PST) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id z4sm2754237wmf.36.2019.11.19.03.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2019 03:10:15 -0800 (PST) Date: Tue, 19 Nov 2019 12:10:12 +0100 From: Ingo Molnar To: Sean Christopherson Message-ID: <20191119111012.GA109842@gmail.com> References: <20191119002121.4107-1-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191119002121.4107-1-sean.j.christopherson@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Wed, 20 Nov 2019 12:02:18 +0100 Cc: Mark Rutland , Cezary Rojewski , linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org, Fenghua Yu , Peter Zijlstra , Jie Yang , alsa-devel@alsa-project.org, Liam Girdwood , Nadav Amit , Pavel Machek , "H. Peter Anvin" , Jiri Olsa , Ard Biesheuvel , linux-acpi@vger.kernel.org, x86@kernel.org, Pierre-Louis Bossart , "VMware, Inc." , Ingo Molnar , Darren Hart , Len Brown , Arnd Bergmann , linux-pm@vger.kernel.org, Arnaldo Carvalho de Melo , Hans de Goede , Mark Brown , Borislav Petkov , Steven Rostedt , Namhyung Kim , Thomas Gleixner , platform-driver-x86@vger.kernel.org, Tony Luck , Greg Kroah-Hartman , "Rafael J. Wysocki" , Takashi Iwai , Alexander Shishkin , linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [alsa-devel] [PATCH 00/12] treewide: break dependencies on x86's RM header X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" * Sean Christopherson wrote: > x86's asm/realmode.h, which defines low level structures, variables and > helpers used to bring up APs during SMP boot, ends up getting included in > practically every nook and cranny of the kernel because the address used > by ACPI for resuming from S3 also happens to be stored in the real mode > header, and ACPI bleeds the dependency into its widely included headers. > > As a result, modifying realmode.h for even the most trivial change to the > boot code triggers a full kernel rebuild, which is frustrating to say the > least as it some of the most difficult code to get exactly right *and* is > also some of the most functionally isolated code in the kernel. > > To break the kernel's widespread dependency on realmode.h, add a wrapper > in the aforementioned ACPI S3 code to access the real mode header instead > of derefencing the header directly in asm/acpi.h and thereby exposing it > to the world via linux/acpi.h. > > Build tested on x86 with allyesconfig and allmodconfig, so hopefully there > aren't more build issues lurking, but at this point it wouldn't surprise > me in the least if this somehow manages to break the build. > > Based on tip/master, commit ceceaf1f12ba ("Merge branch 'WIP.x86/cleanups'"). > > Patch Synopsis: > - Patches 01-09 fix a variety of build errors that arise when patch 12 > drops realmode.h from asm/acpi.h. Most of the errors are quite absurb > as they have no relation whatsoever to x86's RM boot code, but occur > because realmode.h happens to include asm/io.h. Yeah, these kind of parasitic header dependencies are the main driving force behind kernel header spaghetti hell: it's super easy to add a new header, but very hard to remove them... Hence they practically only accumulate. As a result header removal patches get priority, from me at least. :-) > - Patch 10 removes a spurious include of realmode.h from an ACPI header. > > - Patches 11 and 12 implement the wrapper and move it out of acpi.h. So if the ACPI maintainers are fine with -tip carrying patches #11 and #12 then I'd be glad to route these patches upstream. I've applied them to tip:WIP.core/headers as a work-in-progress tree, and I'm testing them on randconfigs to make sure there's no broken dependencies. I'll wait for the ACPI acks. I edited the title of patch 12 slightly, to: c8bceb321209: x86/ACPI/sleep: Move acpi_wakeup_address() definition into sleep.c, remove from to make sure the big header dependency change is obvious at first sight. Thanks, Ingo _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel