From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA4AC432C0 for ; Wed, 20 Nov 2019 11:17:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44A83223D0 for ; Wed, 20 Nov 2019 11:17:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="sV3Ces4a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FM53ORQw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44A83223D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 98A3216F2; Wed, 20 Nov 2019 12:16:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 98A3216F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1574248635; bh=n6vn2g4a63GPcBlpGUu7Rx4aHMlW6g+u0G6ghdfaB3Q=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sV3Ces4a6PYXoZ68MfRxzYSdvG8LUTKFAjKx7QXxJ/K9a/otozVL1zBHg+JawkTGQ o2oIB8sCKwc3Pph07meAhaCT3NqH3R8m27E9aTKLVXHoJU88MODBPdI1iSII99f0FF xVbtl58XyesAcd+uWwPgblqOZpfolHDoFXz4WT2g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 56528F8029B; Wed, 20 Nov 2019 12:02:51 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4CBD7F80137; Tue, 19 Nov 2019 13:22:27 +0100 (CET) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D825CF800F4 for ; Tue, 19 Nov 2019 13:22:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D825CF800F4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FM53ORQw" Received: by mail-wm1-x344.google.com with SMTP id u18so2971230wmc.3 for ; Tue, 19 Nov 2019 04:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pCZ+boQU06taG0uRqRU5p4OOluIcsIWA0zaH1C287a4=; b=FM53ORQwVWjNBirpF/b/+wjx/e/Vkp4KItN0WlU1fYzCw4RAjrqFTtnM1/Uby3dVdK FCJ2nKsQJhpo4l/bZk7Mn4z199l/383/1X7afTKdZblq/CJAKCWCvta88xxwyXl3UZci FtloJoF1fjzEmTqusleWmxmV53XzWbjgfOHucCsGFLIiuaTkoC1uNxNy5sBv/8lhagE6 qPoSqMrrhpbvXhW6fyDB0xkiv1z9FaKX0j/tQHxrrf3tAq/TC3/EF3T/oJvmKOTtL1V4 N712FUpDdceOhaggMDCiLsd2aHyJNLUosvD4PCEhff6lFjUG8qXy5FvJ1ReseK+Bt2hx mF/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=pCZ+boQU06taG0uRqRU5p4OOluIcsIWA0zaH1C287a4=; b=ZyL4f8ZOWddmVbOxcxpuNqVKEivqwPksjr9hPQNvDiyCQg05u0odlgKxV2Upsoqz1s 9NcPK5eP6RMHHCtAXhYPYFfhspDpia8ZP+VC9T85ySPVsxd5famzYoGAWrIGs2N2L7F1 GQSBQKuRJNmA2Q+HK74BqKjDLvDQiAAIfcHNPKcPEV5uKc/8htlFRpSeyXq/MeehWMuM B5Pqrgg7nW5CedSS6Phg/nIMZyDYYFt00MLdhoIYYmbXWr1Xikw7GnhRPIIfb1ph4Qor hg54F+iXoE5Hok+rwnEB0jAjmRHWaVBKJ4BKs4caAuyRkUuIiJmLMuPr8GTdSWvP7vz8 Lguw== X-Gm-Message-State: APjAAAVWMJZuELGqHW41fWlQSpJ1yHST9vgszqvt9IYamkoHfXqHx99Z xknssZH0CKrdAcQm3KVvX6g= X-Google-Smtp-Source: APXvYqx8J0A9Fq4xFkjwZhw6QIza/BfWFpr6MygFUiV3WR/Xgy1tZfffFAp6e+6ePrvxr9A8W8GhgQ== X-Received: by 2002:a1c:a556:: with SMTP id o83mr5077222wme.165.1574166141047; Tue, 19 Nov 2019 04:22:21 -0800 (PST) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id o187sm2916196wmo.20.2019.11.19.04.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2019 04:22:20 -0800 (PST) Date: Tue, 19 Nov 2019 13:22:17 +0100 From: Ingo Molnar To: Ard Biesheuvel Message-ID: <20191119122217.GA24878@gmail.com> References: <20191119002121.4107-1-sean.j.christopherson@intel.com> <20191119111012.GA109842@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Wed, 20 Nov 2019 12:02:18 +0100 Cc: Mark Rutland , Cezary Rojewski , linux-efi , linux-ia64@vger.kernel.org, Fenghua Yu , Peter Zijlstra , Jie Yang , alsa-devel@alsa-project.org, Liam Girdwood , Nadav Amit , Pavel Machek , "H. Peter Anvin" , Jiri Olsa , Ard Biesheuvel , ACPI Devel Maling List , the arch/x86 maintainers , Pierre-Louis Bossart , Alexander Shishkin , Ingo Molnar , Darren Hart , Len Brown , Arnd Bergmann , linux-pm , Arnaldo Carvalho de Melo , Hans de Goede , Mark Brown , Borislav Petkov , Steven Rostedt , Namhyung Kim , Thomas Gleixner , platform-driver-x86@vger.kernel.org, "VMware, Inc." , Tony Luck , Greg Kroah-Hartman , "Rafael J. Wysocki" , Takashi Iwai , Sean Christopherson , Linux Kernel Mailing List , Andy Shevchenko Subject: Re: [alsa-devel] [PATCH 00/12] treewide: break dependencies on x86's RM header X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" * Ard Biesheuvel wrote: > On Tue, 19 Nov 2019 at 12:10, Ingo Molnar wrote: > > > > > > * Sean Christopherson wrote: > > > > > x86's asm/realmode.h, which defines low level structures, variables and > > > helpers used to bring up APs during SMP boot, ends up getting included in > > > practically every nook and cranny of the kernel because the address used > > > by ACPI for resuming from S3 also happens to be stored in the real mode > > > header, and ACPI bleeds the dependency into its widely included headers. > > > > > > As a result, modifying realmode.h for even the most trivial change to the > > > boot code triggers a full kernel rebuild, which is frustrating to say the > > > least as it some of the most difficult code to get exactly right *and* is > > > also some of the most functionally isolated code in the kernel. > > > > > > To break the kernel's widespread dependency on realmode.h, add a wrapper > > > in the aforementioned ACPI S3 code to access the real mode header instead > > > of derefencing the header directly in asm/acpi.h and thereby exposing it > > > to the world via linux/acpi.h. > > > > > > Build tested on x86 with allyesconfig and allmodconfig, so hopefully there > > > aren't more build issues lurking, but at this point it wouldn't surprise > > > me in the least if this somehow manages to break the build. > > > > > > Based on tip/master, commit ceceaf1f12ba ("Merge branch 'WIP.x86/cleanups'"). > > > > > > Patch Synopsis: > > > - Patches 01-09 fix a variety of build errors that arise when patch 12 > > > drops realmode.h from asm/acpi.h. Most of the errors are quite absurb > > > as they have no relation whatsoever to x86's RM boot code, but occur > > > because realmode.h happens to include asm/io.h. > > > > Yeah, these kind of parasitic header dependencies are the main driving > > force behind kernel header spaghetti hell: it's super easy to add a new > > header, but very hard to remove them... > > > > Hence they practically only accumulate. > > > > As a result header removal patches get priority, from me at least. :-) > > > > > - Patch 10 removes a spurious include of realmode.h from an ACPI header. > > > > > > - Patches 11 and 12 implement the wrapper and move it out of acpi.h. > > > > So if the ACPI maintainers are fine with -tip carrying patches #11 and #12 > > then I'd be glad to route these patches upstream. > > > > I've applied them to tip:WIP.core/headers as a work-in-progress tree, and > > I'm testing them on randconfigs to make sure there's no broken > > dependencies. I'll wait for the ACPI acks. > > > > I edited the title of patch 12 slightly, to: > > > > c8bceb321209: x86/ACPI/sleep: Move acpi_wakeup_address() definition into sleep.c, remove from > > > > to make sure the big header dependency change is obvious at first sight. > > > > I'm fine with the patches but can we drop the fixes headers please? > This doesn't actually fix anything, and touching early boot stuff for > no good reason should be avoided imo. Agreed and done. Thanks, Ingo _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel