From: Ingo Molnar <mingo@kernel.org>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org,
Fenghua Yu <fenghua.yu@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Jie Yang <yang.jie@linux.intel.com>,
alsa-devel@alsa-project.org,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Nadav Amit <namit@vmware.com>, Pavel Machek <pavel@ucw.cz>,
"H. Peter Anvin" <hpa@zytor.com>, Jiri Olsa <jolsa@redhat.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-acpi@vger.kernel.org, x86@kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"VMware, Inc." <pv-drivers@vmware.com>,
Ingo Molnar <mingo@redhat.com>,
Darren Hart <dvhart@infradead.org>,
Len Brown <len.brown@intel.com>, Arnd Bergmann <arnd@arndb.de>,
linux-pm@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Brown <broonie@kernel.org>, Borislav Petkov <bp@alien8.de>,
Steven Rostedt <rostedt@goodmis.org>,
Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
platform-driver-x86@vger.kernel.org,
Tony Luck <tony.luck@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Takashi Iwai <tiwai@suse.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [alsa-devel] [PATCH 11/12] ACPI/sleep: Convert acpi_wakeup_address into a function
Date: Tue, 26 Nov 2019 12:16:18 +0100 [thread overview]
Message-ID: <20191126111618.GA28423@gmail.com> (raw)
In-Reply-To: <20191125170034.GB12178@linux.intel.com>
* Sean Christopherson <sean.j.christopherson@intel.com> wrote:
> On Mon, Nov 25, 2019 at 11:48:03AM +0100, Pavel Machek wrote:
> > > On Tuesday, November 19, 2019 1:21:20 AM CET Sean Christopherson wrote:
> > > > Convert acpi_wakeup_address from a raw variable into a function so that
> > > > x86 can wrap its dereference of the real mode boot header in a function
> > > > instead of broadcasting it to the world via a #define. This sets the
> > > > stage for a future patch to move the definition of acpi_wakeup_address()
> > > > out of asm/acpi.h and thus break acpi.h's dependency on asm/realmode.h.
> > > >
> > > > No functional change intended.
> > > >
> > > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> > >
> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > >
> > > > --- a/drivers/acpi/sleep.c
> > > > +++ b/drivers/acpi/sleep.c
> > > > @@ -63,9 +63,9 @@ static int acpi_sleep_prepare(u32 acpi_state)
> > > > #ifdef CONFIG_ACPI_SLEEP
> > > > /* do we have a wakeup address for S2 and S3? */
> > > > if (acpi_state == ACPI_STATE_S3) {
> > > > - if (!acpi_wakeup_address)
> > > > + if (!acpi_wakeup_address())
> > > > return -EFAULT;
> > > > - acpi_set_waking_vector(acpi_wakeup_address);
> > > > + acpi_set_waking_vector(acpi_wakeup_address());
> > > >
> >
> > You might want to store result in a variable... especially since you are
> > turning inline function into real one in a next patch.
> >
> > And maybe function should be called get_acip_wakeup_address or
> > something? This way it is easy to mistake actual wakeup address from
> > function that gets it...
>
> Agreed on both counts.
>
>
> Ingo,
>
> Would you prefer a v2 of the entire series (with Acks and removal of Fixes),
> or a v2 that includes only the last two patches?
Yep, that would be handy. I have them committed to tip:core/headers, but
haven't sent it to Linus yet, and can redo that all with these
improvements.
Thanks,
Ingo
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-27 6:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 0:21 [alsa-devel] [PATCH 00/12] treewide: break dependencies on x86's RM header Sean Christopherson
2019-11-19 0:21 ` [alsa-devel] [PATCH 01/12] x86/efi: Explicitly include realmode.h to handle RM trampoline quirk Sean Christopherson
2019-11-19 0:21 ` [alsa-devel] [PATCH 02/12] x86/boot: Explicitly include realmode.h to handle RM reservations Sean Christopherson
2019-11-19 0:21 ` [alsa-devel] [PATCH 03/12] x86/ftrace: Explicitly include vmalloc.h for set_vm_flush_reset_perms() Sean Christopherson
2019-11-22 2:11 ` Steven Rostedt
2019-11-19 0:21 ` [alsa-devel] [PATCH 04/12] x86/kprobes: " Sean Christopherson
2019-11-22 2:12 ` Steven Rostedt
2019-11-19 0:21 ` [alsa-devel] [PATCH 05/12] perf/x86/intel: Explicitly include asm/io.h to use virt_to_phys() Sean Christopherson
2019-11-19 0:21 ` [alsa-devel] [PATCH 06/12] efi/capsule-loader: Explicitly include linux/io.h for page_to_phys() Sean Christopherson
2019-11-19 0:21 ` [alsa-devel] [PATCH 07/12] virt: vbox: Explicitly include linux/io.h to pick up various defs Sean Christopherson
2019-11-19 0:21 ` [alsa-devel] [PATCH 08/12] vmw_balloon: Explicitly include linux/io.h for virt_to_phys() Sean Christopherson
2019-11-19 0:21 ` [alsa-devel] [PATCH 09/12] ASoC: Intel: Skylake: " Sean Christopherson
2019-11-19 12:00 ` Mark Brown
2019-11-19 0:21 ` [alsa-devel] [PATCH 10/12] x86/ACPI/sleep: Remove an unnecessary include of asm/realmode.h Sean Christopherson
2019-11-20 10:59 ` Rafael J. Wysocki
2019-11-19 0:21 ` [alsa-devel] [PATCH 11/12] ACPI/sleep: Convert acpi_wakeup_address into a function Sean Christopherson
2019-11-20 10:58 ` Rafael J. Wysocki
2019-11-25 10:48 ` Pavel Machek
2019-11-25 17:00 ` Sean Christopherson
2019-11-26 11:16 ` Ingo Molnar [this message]
2019-11-26 11:25 ` Ingo Molnar
2019-11-19 0:21 ` [alsa-devel] [PATCH 12/12] x86/ACPI/sleep: Move acpi_wakeup_address() definition into sleep.c Sean Christopherson
2019-11-20 11:00 ` Rafael J. Wysocki
2019-11-19 11:10 ` [alsa-devel] [PATCH 00/12] treewide: break dependencies on x86's RM header Ingo Molnar
2019-11-19 12:06 ` [alsa-devel] [PATCH] x86/platform/intel/quark: Explicitly include linux/io.h for virt_to_phys() Ingo Molnar
2019-11-19 12:38 ` Andy Shevchenko
2019-11-19 12:09 ` [alsa-devel] [PATCH 00/12] treewide: break dependencies on x86's RM header Ard Biesheuvel
2019-11-19 12:22 ` Ingo Molnar
2019-11-19 12:33 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126111618.GA28423@gmail.com \
--to=mingo@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy@infradead.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=dvhart@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=len.brown@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=namit@vmware.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).