Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Curtis Malainey <cujomalainey@google.com>
Cc: Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>,
	Curtis Malainey <cujomalainey@chromium.org>,
	ALSA development <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: core: only flush inited work during free
Date: Thu, 28 Nov 2019 17:28:32 +0000
Message-ID: <20191128172832.GF4210@sirena.org.uk> (raw)
In-Reply-To: <CAOReqxj1V475mbfSEWNn3NrMJDttO+23KjboBR01tGhzAAJmBw@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 804 bytes --]

On Thu, Nov 28, 2019 at 08:23:21AM -0800, Curtis Malainey wrote:
> On Thu, Nov 28, 2019 at 5:49 AM Mark Brown <broonie@kernel.org> wrote:

> > > For this delayed_work, the situation is a bit complex, though.
> > > Usually the work is set up to point to a fixed function, but in the
> > > case of ASoC, it seems serving for different purposes depending on the
> > > component type.  I guess the cleaner way would be a redirect call
> > > like:

> > Yes, or just separate fields for each.


> Sounds good, I will refactor this change and send a new version next
> week as US is on holiday rest of this week.

I applied the change as-is already since like Takashi says it is an
improvement in itself but obviously doing something more complete and
thorough on top of it would be great if you have the time!

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28  1:13 Curtis Malainey
2019-11-28  6:39 ` Takashi Iwai
2019-11-28 13:49   ` Mark Brown
2019-11-28 16:23     ` Curtis Malainey
2019-11-28 17:28       ` Mark Brown [this message]
2019-12-02 22:50         ` Curtis Malainey
2019-12-09 18:59 ` [alsa-devel] Applied "ASoC: core: only flush inited work during free" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191128172832.GF4210@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=cujomalainey@chromium.org \
    --cc=cujomalainey@google.com \
    --cc=lgirdwood@gmail.com \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git