From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
tiwai@suse.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
vkoul@kernel.org, broonie@kernel.org,
srinivas.kandagatla@linaro.org, jank@cadence.com,
slawomir.blauciak@intel.com,
Sanyog Kale <sanyog.r.kale@intel.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: [alsa-devel] [PATCH v5 08/11] soundwire: intel: add link_list to handle interrupts with a single thread
Date: Wed, 11 Dec 2019 19:45:04 -0600 [thread overview]
Message-ID: <20191212014507.28050-9-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20191212014507.28050-1-pierre-louis.bossart@linux.intel.com>
From: Bard Liao <yung-chuan.liao@linux.intel.com>
In MSI mode, the use of separate handlers and threads for the Intel
IPC, stream and SoundWire shared interrupt leads to timeouts and lost
interrupts.
The solution is to merge all interrupt handling across all links with
a single thread function. The use of a linked list enables this thread
function to walk through all contexts and figure out which link needs
attention.
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
include/linux/soundwire/sdw_intel.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/soundwire/sdw_intel.h b/include/linux/soundwire/sdw_intel.h
index 2ce3e9ecc4b6..2a56180bc9dc 100644
--- a/include/linux/soundwire/sdw_intel.h
+++ b/include/linux/soundwire/sdw_intel.h
@@ -70,6 +70,7 @@ struct sdw_intel_link_res;
* @handle: ACPI parent handle
* @links: information for each link (controller-specific and kept
* opaque here)
+ * @link_list: list to handle interrupts across all links
*/
struct sdw_intel_ctx {
int count;
@@ -77,6 +78,7 @@ struct sdw_intel_ctx {
u32 link_mask;
acpi_handle handle;
struct sdw_intel_link_res *links;
+ struct list_head link_list;
};
/**
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-12 1:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 1:44 [alsa-devel] [PATCH v5 00/11] soundwire: update ASoC interfaces Pierre-Louis Bossart
2019-12-12 1:44 ` [alsa-devel] [PATCH v5 01/11] soundwire: sdw_slave: add probe_complete structure and new fields Pierre-Louis Bossart
2019-12-12 1:44 ` [alsa-devel] [PATCH v5 02/11] soundwire: sdw_slave: add enumeration_complete structure Pierre-Louis Bossart
2019-12-12 1:44 ` [alsa-devel] [PATCH v5 03/11] soundwire: sdw_slave: add initialization_complete definition Pierre-Louis Bossart
2019-12-12 1:45 ` [alsa-devel] [PATCH v5 04/11] soundwire: sdw_slave: track unattach_request to handle all init sequences Pierre-Louis Bossart
2019-12-12 1:45 ` [alsa-devel] [PATCH v5 05/11] soundwire: intel: update interfaces between ASoC and SoundWire Pierre-Louis Bossart
2019-12-12 1:45 ` [alsa-devel] [PATCH v5 06/11] soundwire: intel: update stream callbacks for hwparams/free stream operations Pierre-Louis Bossart
2019-12-12 1:45 ` [alsa-devel] [PATCH v5 07/11] soundwire: intel: update headers for interrupts Pierre-Louis Bossart
2019-12-12 1:45 ` Pierre-Louis Bossart [this message]
2019-12-12 1:45 ` [alsa-devel] [PATCH v5 09/11] soundwire: intel: add prototype for WAKEEN interrupt processing Pierre-Louis Bossart
2019-12-12 1:45 ` [alsa-devel] [PATCH v5 10/11] soundwire: intel: add mutex for shared SHIM register access Pierre-Louis Bossart
2019-12-12 1:45 ` [alsa-devel] [PATCH v5 11/11] soundwire: intel: add clock stop quirks Pierre-Louis Bossart
2019-12-12 3:49 ` [alsa-devel] [PATCH v5 00/11] soundwire: update ASoC interfaces Vinod Koul
2019-12-12 14:37 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212014507.28050-9-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).