From: Mark Brown <broonie@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: alsa-devel@alsa-project.org,
'Linux Samsung SOC' <linux-samsung-soc@vger.kernel.org>,
cychiang@google.com, Krzysztof Kozlowski <krzk@kernel.org>,
Tzung-Bi Shih <tzungbi@google.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
dgreid@google.com
Subject: Re: [alsa-devel] [PATCH v2] ASoC: max98090: save and restore SHDN when changing sensitive registers
Date: Thu, 12 Dec 2019 16:48:09 +0000 [thread overview]
Message-ID: <20191212164809.GH4310@sirena.org.uk> (raw)
In-Reply-To: <129540e9-a4e8-3d01-41bc-e7c9c04bbefe@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 1108 bytes --]
On Thu, Dec 12, 2019 at 05:02:50PM +0100, Marek Szyprowski wrote:
> On 12.12.2019 15:09, Marek Szyprowski wrote:
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
> >> +static void max98090_shdn_save(struct max98090_priv *max98090)
> >> +{
> >> + mutex_lock(&max98090->component->card->dapm_mutex);
> The NULL pointer dereference demonstrated above is caused by
> max98090->component->card being NULL here. Adding a simple != NULL check
> here and in the max98090_shdn_restore() function fixes the boot issue,
> although the deplock warning is still there. The question is that is the
> max98090->component->card being NULL is a normal case or something that
> needs further analysis.
It'd be good to get a bit more analysis, the _shdn_save() call looks to
have come from a userspace write and we shouldn't be exposing the card
and hence the controls on the card to userspace until it's fully
instantiated.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-12 16:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191128152110epcas3p2b205b4b55f6d8bfac42fcb8faaade93c@epcas3p2.samsung.com>
2019-11-28 15:19 ` [alsa-devel] [PATCH v2] ASoC: max98090: save and restore SHDN when changing sensitive registers Tzung-Bi Shih
2019-12-09 18:59 ` [alsa-devel] Applied "ASoC: max98090: save and restore SHDN when changing sensitive registers" to the asoc tree Mark Brown
2019-12-12 14:09 ` [alsa-devel] [PATCH v2] ASoC: max98090: save and restore SHDN when changing sensitive registers Marek Szyprowski
2019-12-12 16:02 ` Marek Szyprowski
2019-12-12 16:48 ` Mark Brown [this message]
2019-12-12 18:05 ` Tzung-Bi Shih
2019-12-17 14:18 ` Marek Szyprowski
2019-12-18 13:26 ` Mark Brown
2019-12-18 14:48 ` Marek Szyprowski
2019-12-18 16:24 ` Mark Brown
2019-12-19 8:03 ` Marek Szyprowski
2019-12-19 12:37 ` Mark Brown
2019-12-19 12:54 ` Marek Szyprowski
2019-12-19 13:05 ` Mark Brown
2019-12-19 13:41 ` Marek Szyprowski
2019-12-19 19:16 ` Mark Brown
2019-12-20 8:28 ` Marek Szyprowski
2019-12-20 9:05 ` Marek Szyprowski
2019-12-20 12:01 ` Mark Brown
2020-01-08 11:54 ` Marek Szyprowski
2020-01-09 21:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212164809.GH4310@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cychiang@google.com \
--cc=dgreid@google.com \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).