Re: [alsa-devel] [PATCH] ALSA: usb-audio: Add support for Presonus Studio 1810c

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3247 bytes --]

Hi,

I love your patch! Yet something to improve:

[auto build test ERROR on sound/for-next]
[cannot apply to v5.5-rc3 next-20191220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/mickflemm-gmail-com/ALSA-usb-audio-Add-support-for-Presonus-Studio-1810c/20191226-163321
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   sound/usb/mixer_s1810c.c: In function 'snd_sc1810_mixer_state_free':
>> sound/usb/mixer_s1810c.c:507:2: error: implicit declaration of function 'vfree'; did you mean 'kfree'? [-Werror=implicit-function-declaration]
     vfree(private);
     ^~~~~
     kfree
   sound/usb/mixer_s1810c.c: In function 'snd_sc1810_init_mixer':
>> sound/usb/mixer_s1810c.c:536:12: error: implicit declaration of function 'vzalloc'; did you mean 'kzalloc'? [-Werror=implicit-function-declaration]
     private = vzalloc(sizeof(struct s1810_mixer_state));
               ^~~~~~~
               kzalloc
>> sound/usb/mixer_s1810c.c:536:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     private = vzalloc(sizeof(struct s1810_mixer_state));
             ^
   cc1: some warnings being treated as errors

vim +507 sound/usb/mixer_s1810c.c

   503	
   504	static void snd_sc1810_mixer_state_free(struct usb_mixer_interface *mixer)
   505	{
   506		struct s1810_mixer_state *private = mixer->private_data;
 > 507		vfree(private);
   508		mixer->private_data = NULL;
   509	}
   510	
   511	/* Entry point, called from mixer_quirks.c */
   512	int snd_sc1810_init_mixer(struct usb_mixer_interface *mixer)
   513	{
   514		struct s1810_mixer_state *private = NULL;
   515		struct snd_usb_audio *chip = mixer->chip;
   516		struct usb_device *dev = chip->dev;
   517		int ret = 0;
   518	
   519		/* Run this only once */
   520		if (!list_empty(&chip->mixer_list))
   521			return 0;
   522	
   523		dev_info(&dev->dev,
   524			 "Presonus Studio 1810c, device_setup: %u\n", chip->setup);
   525		if (chip->setup == 1)
   526			dev_info(&dev->dev, "(8out/18in @ 48KHz)\n");
   527		else if (chip->setup == 2)
   528			dev_info(&dev->dev, "(6out/8in @ 192KHz)\n");
   529		else
   530			dev_info(&dev->dev, "(8out/14in @ 96KHz)\n");
   531	
   532		ret = snd_s1810c_init_mixer_maps(chip);
   533		if (ret < 0)
   534			return ret;
   535	
 > 536		private = vzalloc(sizeof(struct s1810_mixer_state));

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51897 bytes --]

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel