From: Takashi Iwai <tiwai@suse.de> To: alsa-devel@alsa-project.org Subject: [alsa-devel] [PATCH 51/58] ALSA: usx2y: Constify struct snd_usb_audio_quirk entries Date: Fri, 3 Jan 2020 09:17:07 +0100 Message-ID: <20200103081714.9560-52-tiwai@suse.de> (raw) In-Reply-To: <20200103081714.9560-1-tiwai@suse.de> The quirk entries used in us122l and usx2y drivers can be declared as const as they are read-only. There should be no functional changes by this patch. Signed-off-by: Takashi Iwai <tiwai@suse.de> --- sound/usb/usx2y/us122l.c | 8 ++++---- sound/usb/usx2y/usX2Yhwdep.c | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/sound/usb/usx2y/us122l.c b/sound/usb/usx2y/us122l.c index e82c5236482d..f86f7a61fb36 100644 --- a/sound/usb/usx2y/us122l.c +++ b/sound/usb/usx2y/us122l.c @@ -40,13 +40,13 @@ static int snd_us122l_card_used[SNDRV_CARDS]; static int us122l_create_usbmidi(struct snd_card *card) { - static struct snd_usb_midi_endpoint_info quirk_data = { + static const struct snd_usb_midi_endpoint_info quirk_data = { .out_ep = 4, .in_ep = 3, .out_cables = 0x001, .in_cables = 0x001 }; - static struct snd_usb_audio_quirk quirk = { + static const struct snd_usb_audio_quirk quirk = { .vendor_name = "US122L", .product_name = NAME_ALLCAPS, .ifnum = 1, @@ -62,13 +62,13 @@ static int us122l_create_usbmidi(struct snd_card *card) static int us144_create_usbmidi(struct snd_card *card) { - static struct snd_usb_midi_endpoint_info quirk_data = { + static const struct snd_usb_midi_endpoint_info quirk_data = { .out_ep = 4, .in_ep = 3, .out_cables = 0x001, .in_cables = 0x001 }; - static struct snd_usb_audio_quirk quirk = { + static const struct snd_usb_audio_quirk quirk = { .vendor_name = "US144", .product_name = NAME_ALLCAPS, .ifnum = 0, diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c index 9985fc139487..0e6d82b5778e 100644 --- a/sound/usb/usx2y/usX2Yhwdep.c +++ b/sound/usb/usx2y/usX2Yhwdep.c @@ -126,26 +126,26 @@ static int snd_usX2Y_hwdep_dsp_status(struct snd_hwdep *hw, static int usX2Y_create_usbmidi(struct snd_card *card) { - static struct snd_usb_midi_endpoint_info quirk_data_1 = { + static const struct snd_usb_midi_endpoint_info quirk_data_1 = { .out_ep = 0x06, .in_ep = 0x06, .out_cables = 0x001, .in_cables = 0x001 }; - static struct snd_usb_audio_quirk quirk_1 = { + static const struct snd_usb_audio_quirk quirk_1 = { .vendor_name = "TASCAM", .product_name = NAME_ALLCAPS, .ifnum = 0, .type = QUIRK_MIDI_FIXED_ENDPOINT, .data = &quirk_data_1 }; - static struct snd_usb_midi_endpoint_info quirk_data_2 = { + static const struct snd_usb_midi_endpoint_info quirk_data_2 = { .out_ep = 0x06, .in_ep = 0x06, .out_cables = 0x003, .in_cables = 0x003 }; - static struct snd_usb_audio_quirk quirk_2 = { + static const struct snd_usb_audio_quirk quirk_2 = { .vendor_name = "TASCAM", .product_name = "US428", .ifnum = 0, @@ -154,7 +154,7 @@ static int usX2Y_create_usbmidi(struct snd_card *card) }; struct usb_device *dev = usX2Y(card)->dev; struct usb_interface *iface = usb_ifnum_to_if(dev, 0); - struct snd_usb_audio_quirk *quirk = + const struct snd_usb_audio_quirk *quirk = le16_to_cpu(dev->descriptor.idProduct) == USB_ID_US428 ? &quirk_2 : &quirk_1; -- 2.16.4 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply index Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-03 8:16 [alsa-devel] [PATCH 00/58] ALSA: Constifications Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 01/58] ALSA: pci: Constify snd_pcm_hardware definitions Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 02/58] ALSA: usb: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 03/58] ALSA: core: Treat snd_device_ops as const Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 04/58] ALSA: core: Constify snd_device_ops definitions Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 05/58] ALSA: drivers: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 06/58] ALSA: i2c: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 07/58] ALSA: isa: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 08/58] ALSA: hda: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 09/58] ALSA: pci: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 10/58] ALSA: usb: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 11/58] ALSA: aoa: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 12/58] ALSA: mips: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 13/58] ALSA: parisc: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 14/58] ALSA: pcmcia: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 15/58] ALSA: ppc: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 16/58] ALSA: sparc: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 17/58] ALSA: sh: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 18/58] ALSA: spi: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 19/58] ALSA: docs: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 20/58] ALSA: timer: Constify snd_timer_hardware definitions Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 21/58] ALSA: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 22/58] ALSA: ac97: Treat snd_ac97_bus_ops as const Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 23/58] ALSA: ac97: Constify snd_ac97_bus_ops definitions Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 24/58] ALSA: arm: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 25/58] ALSA: atmel: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 26/58] ALSA: drivers: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 27/58] ALSA: pci: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 28/58] ALSA: info: Make snd_info_entry_ops as const Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 29/58] ALSA: seq: Constify struct snd_midi_op Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 30/58] ALSA: vx: Constify snd_vx_hardware and snd_vx_ops definitions Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 31/58] ALSA: mixer: oss: Constify snd_mixer_oss_assign_table definition Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 32/58] ALSA: aoa: Constify snd_kcontrol_new items Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 33/58] ALSA: drivers: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 34/58] ALSA: i2c: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 35/58] ALSA: isa: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 36/58] ALSA: hda: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 37/58] ALSA: pci: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 38/58] ALSA: ppc: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 39/58] ALSA: sparc: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 40/58] ALSA: spi: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 41/58] ALSA: usb: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 42/58] ALSA: parisc: " Takashi Iwai 2020-01-03 8:16 ` [alsa-devel] [PATCH 43/58] ALSA: dummy: Constify snd_pcm_ops definitions Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 44/58] ALSA: opl3: Constify snd_opl3_drum_voice definitions Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 45/58] ALSA: ac97: Constify snd_ac97_res_table definition Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 46/58] ALSA: ca0106: Constify snd_ca0106_category_str items Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 47/58] ALSA: ca0106: Constify snd_ca0106_details Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 48/58] ALSA: ice17xx: Constify snd_ice1712_card_info Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 49/58] ALSA: ice1712: Constify wm-specific tables Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 50/58] ALSA: line6: Constify snd_ratden definitions Takashi Iwai 2020-01-03 8:17 ` Takashi Iwai [this message] 2020-01-03 8:17 ` [alsa-devel] [PATCH 52/58] ALSA: seq: oss: Constify snd_seq_oss_callback definitions Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 53/58] ALSA: bt87x: Constify snd_bt87x_boards Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 54/58] ALSA: emu10k1: Constify snd_emu_chip_details Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 55/58] ALSA: es1968: Constify snd_es1968_tea575x_gpios Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 56/58] ALSA: fm801: Constify snd_fm801_tea575x_gpios Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 57/58] ALSA: hda: Constify snd_pci_quirk tables Takashi Iwai 2020-01-03 8:17 ` [alsa-devel] [PATCH 58/58] ALSA: pci: " Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200103081714.9560-52-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Alsa-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \ alsa-devel@alsa-project.org public-inbox-index alsa-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git