From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Jonathan Corbet <corbet@lwn.net>,
tiwai@suse.de, gregkh@linuxfoundation.org,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
broonie@kernel.org, srinivas.kandagatla@linaro.org,
jank@cadence.com, slawomir.blauciak@intel.com,
Sanyog Kale <sanyog.r.kale@intel.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH 2/6] soundwire: stream: update state machine and add state checks
Date: Fri, 10 Jan 2020 12:18:38 +0530 [thread overview]
Message-ID: <20200110064838.GY2818@vkoul-mobl> (raw)
In-Reply-To: <20200108175438.13121-3-pierre-louis.bossart@linux.intel.com>
On 08-01-20, 11:54, Pierre-Louis Bossart wrote:
> Stream State Operations
> -----------------------
> @@ -246,6 +251,9 @@ SDW_STREAM_PREPARED
>
> Prepare state of stream. Operations performed before entering in this state:
>
> + (0) Steps 1 and 2 are omitted in the case of a resume operation,
> + where the bus bandwidth is known.
> +
> (1) Bus parameters such as bandwidth, frame shape, clock frequency,
> are computed based on current stream as well as already active
> stream(s) on Bus. Re-computation is required to accommodate current
> @@ -270,13 +278,15 @@ Prepare state of stream. Operations performed before entering in this state:
> After all above operations are successful, stream state is set to
> ``SDW_STREAM_PREPARED``.
>
> -Bus implements below API for PREPARE state which needs to be called once per
> -stream. From ASoC DPCM framework, this stream state is linked to
> -.prepare() operation.
> +Bus implements below API for PREPARE state which needs to be called
> +once per stream. From ASoC DPCM framework, this stream state is linked
> +to .prepare() operation. Since the .trigger() operations may not
> +follow the .prepare(), a direct transitions from
> +``SDW_STREAM_PREPARED`` to ``SDW_STREAM_DEPREPARED`` is allowed.
>
> .. code-block:: c
>
> - int sdw_prepare_stream(struct sdw_stream_runtime * stream);
> + int sdw_prepare_stream(struct sdw_stream_runtime * stream, bool resume);
so what does the additional argument of resume do..?
> diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
> index 178ae92b8cc1..6aa0b5d370c0 100644
> --- a/drivers/soundwire/stream.c
> +++ b/drivers/soundwire/stream.c
> @@ -1553,8 +1553,18 @@ int sdw_prepare_stream(struct sdw_stream_runtime *stream)
and it is not modified here, so is the doc correct or this..?
--
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-10 6:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 17:54 [alsa-devel] [PATCH 0/6] soundwire: stream: fix state machines and transitions Pierre-Louis Bossart
2020-01-08 17:54 ` [alsa-devel] [PATCH 1/6] soundwire: stream: remove redundant pr_err traces Pierre-Louis Bossart
2020-01-10 7:04 ` Vinod Koul
2020-01-08 17:54 ` [alsa-devel] [PATCH 2/6] soundwire: stream: update state machine and add state checks Pierre-Louis Bossart
2020-01-10 6:48 ` Vinod Koul [this message]
2020-01-10 16:30 ` Pierre-Louis Bossart
2020-01-11 11:30 ` Pierre-Louis Bossart
2020-01-13 5:22 ` Vinod Koul
2020-01-08 17:54 ` [alsa-devel] [PATCH 3/6] soundwire: stream: only prepare stream when it is configured Pierre-Louis Bossart
2020-01-08 17:54 ` [alsa-devel] [PATCH 4/6] soundwire: stream: do not update parameters during DISABLED-PREPARED transition Pierre-Louis Bossart
2020-01-10 6:55 ` Vinod Koul
2020-01-10 16:11 ` Pierre-Louis Bossart
2020-01-08 17:54 ` [alsa-devel] [PATCH 5/6] soundwire: stream: fix support for multiple Slaves on the same link Pierre-Louis Bossart
2020-01-08 17:54 ` [alsa-devel] [PATCH 6/6] soundwire: stream: don't program ports for a stream that has not been prepared Pierre-Louis Bossart
2020-01-10 7:03 ` Vinod Koul
2020-01-10 16:24 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110064838.GY2818@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).