Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [alsa-devel] [PATCH] ALSA: usb-audio: add implicit fb quirk for MOTU M Series
@ 2020-01-15 15:13 Alexander Tsoy
  2020-01-16  9:46 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Tsoy @ 2020-01-15 15:13 UTC (permalink / raw)
  To: alsa-devel; +Cc: Takashi Iwai

This fixes crackling sound during playback.

Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
---

MOTU is known for reusing Product IDs for different devices or different
generations of the device (e.g. MicroBook I/II/IIc shares a single Product
ID). This patch was only tested with M4 audio interface, but the same
Product ID is also used by M2. Hope it will work for M2 as well.

 sound/usb/pcm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index a11c8150af58..4f1c00615d94 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -348,6 +348,10 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
 		ep = 0x84;
 		ifnum = 0;
 		goto add_sync_ep_from_ifnum;
+	case USB_ID(0x07fd, 0x0008): /* MOTU M Series */
+		ep = 0x81;
+		ifnum = 2;
+		goto add_sync_ep_from_ifnum;
 	case USB_ID(0x0582, 0x01d8): /* BOSS Katana */
 		/* BOSS Katana amplifiers do not need quirks */
 		return 0;
-- 
2.24.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [alsa-devel] [PATCH] ALSA: usb-audio: add implicit fb quirk for MOTU M Series
  2020-01-15 15:13 [alsa-devel] [PATCH] ALSA: usb-audio: add implicit fb quirk for MOTU M Series Alexander Tsoy
@ 2020-01-16  9:46 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-01-16  9:46 UTC (permalink / raw)
  To: Alexander Tsoy; +Cc: alsa-devel

On Wed, 15 Jan 2020 16:13:58 +0100,
Alexander Tsoy wrote:
> 
> This fixes crackling sound during playback.
> 
> Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
> ---
> 
> MOTU is known for reusing Product IDs for different devices or different
> generations of the device (e.g. MicroBook I/II/IIc shares a single Product
> ID). This patch was only tested with M4 audio interface, but the same
> Product ID is also used by M2. Hope it will work for M2 as well.

Applied now.

I copied this note to the changelog as it's a pretty useful
information, too.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 15:13 [alsa-devel] [PATCH] ALSA: usb-audio: add implicit fb quirk for MOTU M Series Alexander Tsoy
2020-01-16  9:46 ` Takashi Iwai

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git