* [alsa-devel] [PATCH] soundwire: cadence: fix kernel-doc parameter descriptions
@ 2020-01-14 23:31 Pierre-Louis Bossart
2020-01-16 12:04 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-14 23:31 UTC (permalink / raw)
To: alsa-devel
Cc: Pierre-Louis Bossart, tiwai, gregkh, linux-kernel,
Ranjani Sridharan, vkoul, broonie, srinivas.kandagatla, jank,
slawomir.blauciak, Sanyog Kale, Bard liao, Rander Wang
Fix previous update, bad git merge likely. oops.
Fixes: 39737a313085fa ("soundwire: cadence: update kernel-doc parameter descriptions")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
drivers/soundwire/cadence_master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
index 12d3ac56e01b..9bec270d0fa4 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -819,7 +819,6 @@ EXPORT_SYMBOL(sdw_cdns_thread);
/**
* sdw_cdns_exit_reset() - Program reset parameters and start bus operations
* @cdns: Cadence instance
- * @state: True if we are trying to enable interrupt.
*/
int sdw_cdns_exit_reset(struct sdw_cdns *cdns)
{
@@ -846,6 +845,7 @@ EXPORT_SYMBOL(sdw_cdns_exit_reset);
/**
* sdw_cdns_enable_interrupt() - Enable SDW interrupts
* @cdns: Cadence instance
+ * @state: True if we are trying to enable interrupt.
*/
int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns, bool state)
{
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] soundwire: cadence: fix kernel-doc parameter descriptions
2020-01-14 23:31 [alsa-devel] [PATCH] soundwire: cadence: fix kernel-doc parameter descriptions Pierre-Louis Bossart
@ 2020-01-16 12:04 ` Vinod Koul
2020-01-16 12:09 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Vinod Koul @ 2020-01-16 12:04 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: alsa-devel, tiwai, gregkh, linux-kernel, Ranjani Sridharan,
broonie, srinivas.kandagatla, jank, slawomir.blauciak,
Sanyog Kale, Bard liao, Rander Wang
On 14-01-20, 17:31, Pierre-Louis Bossart wrote:
> Fix previous update, bad git merge likely. oops.
Applied, thanks
--
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] soundwire: cadence: fix kernel-doc parameter descriptions
2020-01-16 12:04 ` Vinod Koul
@ 2020-01-16 12:09 ` Vinod Koul
2020-01-16 14:27 ` Pierre-Louis Bossart
0 siblings, 1 reply; 4+ messages in thread
From: Vinod Koul @ 2020-01-16 12:09 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: alsa-devel, tiwai, gregkh, linux-kernel, Ranjani Sridharan,
broonie, srinivas.kandagatla, jank, slawomir.blauciak,
Sanyog Kale, Bard liao, Rander Wang
On 16-01-20, 17:35, Vinod Koul wrote:
> On 14-01-20, 17:31, Pierre-Louis Bossart wrote:
> > Fix previous update, bad git merge likely. oops.
>
> Applied, thanks
Btw I still have these warns on my next with W=1
drivers/soundwire/intel_init.c:193:7: warning: no previous prototype for ‘sdw_intel_init’ [-Wmissing-prototypes]
void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res)
^~~~~~~~~~~~~~
drivers/soundwire/cadence_master.c:1022: warning: Function parameter or member 'clock_stop_exit' not described in 'sdw_cdns_init'
LD [M] drivers/soundwire/soundwire-cadence.o
drivers/soundwire/intel_init.c:214: warning: Function parameter or member 'ctx' not described in 'sdw_intel_exit'
drivers/soundwire/intel_init.c:214: warning: Excess function parameter 'arg' description in 'sdw_intel_exit'
--
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] soundwire: cadence: fix kernel-doc parameter descriptions
2020-01-16 12:09 ` Vinod Koul
@ 2020-01-16 14:27 ` Pierre-Louis Bossart
0 siblings, 0 replies; 4+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-16 14:27 UTC (permalink / raw)
To: Vinod Koul
Cc: alsa-devel, tiwai, gregkh, linux-kernel, Ranjani Sridharan,
broonie, srinivas.kandagatla, jank, slawomir.blauciak,
Sanyog Kale, Bard liao, Rander Wang
On 1/16/20 6:09 AM, Vinod Koul wrote:
> On 16-01-20, 17:35, Vinod Koul wrote:
>> On 14-01-20, 17:31, Pierre-Louis Bossart wrote:
>>> Fix previous update, bad git merge likely. oops.
>>
>> Applied, thanks
>
> Btw I still have these warns on my next with W=1
>
> drivers/soundwire/intel_init.c:193:7: warning: no previous prototype for ‘sdw_intel_init’ [-Wmissing-prototypes]
> void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res)
> ^~~~~~~~~~~~~~
> drivers/soundwire/cadence_master.c:1022: warning: Function parameter or member 'clock_stop_exit' not described in 'sdw_cdns_init'
> LD [M] drivers/soundwire/soundwire-cadence.o
> drivers/soundwire/intel_init.c:214: warning: Function parameter or member 'ctx' not described in 'sdw_intel_exit'
> drivers/soundwire/intel_init.c:214: warning: Excess function parameter 'arg' description in 'sdw_intel_exit'
All of this is replaced by new code already submitted for review. try
our SOF upstream/soundwire branch and you'll see.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-16 15:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-14 23:31 [alsa-devel] [PATCH] soundwire: cadence: fix kernel-doc parameter descriptions Pierre-Louis Bossart
2020-01-16 12:04 ` Vinod Koul
2020-01-16 12:09 ` Vinod Koul
2020-01-16 14:27 ` Pierre-Louis Bossart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).