From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>,
ALSA development <alsa-devel@alsa-project.org>,
Kailang Yang <kailang@realtek.com>
Subject: Re: [alsa-devel] [PATCH] ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen
Date: Mon, 10 Feb 2020 11:52:49 +0900 [thread overview]
Message-ID: <20200210025249.GA2700@f3> (raw)
In-Reply-To: <20191129144027.14765-1-perex@perex.cz>
On 2019/11/29 15:40 +0100, Jaroslav Kysela wrote:
> The auto-parser assigns the bass speaker to DAC3 (NID 0x06) which
> is without the volume control. I do not see a reason to use DAC2,
> because the shared output to all speakers produces the sufficient
> and well balanced sound. The stereo support is enough for this
> purpose (laptop).
>
> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
> ---
> sound/pci/hda/patch_realtek.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
This patch is now commit d2cd795c4ece ("ALSA: hda - fixup for the bass
speaker on Lenovo Carbon X1 7th gen"). There was then followup commit
86353aa70ed0 ("ALSA: hda/realtek - Add quirk for the bass speaker on
Lenovo Yoga X1 7th gen").
As a result of those, the maximum sound output level on my laptop
reduced to ~60% of what it used to be.
Moreover, the quirk name is inaccurate. I have a "ThinkPad X1 Carbon
7th" (as confirmed by dmidecode) and its audio device id is:
Subsystem: Lenovo Cannon Point-LP High Definition Audio Controller [17aa:2292]
but the patches list:
SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Yoga 7th", ALC285_FIXUP_SPEAKER2_TO_DAC1),
SND_PCI_QUIRK(0x17aa, 0x2293, "Thinkpad X1 Carbon 7th", ALC295_FIXUP_DISABLE_DAC3),
(notice the mixup of id 0x2292).
Applying the following diff brings the volume back to previous levels
and brings functional volume control:
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 68832f52c1ad..ed41e3fb5566 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7260,7 +7260,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
- SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Yoga 7th", ALC285_FIXUP_SPEAKER2_TO_DAC1),
+ SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Yoga 7th", ALC295_FIXUP_DISABLE_DAC3),
SND_PCI_QUIRK(0x17aa, 0x2293, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_SPEAKER2_TO_DAC1),
SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
I can send a patch to fix the problems for my laptop but then I don't
know what's up for other devices that built on
ALC285_FIXUP_SPEAKER2_TO_DAC1.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-02-10 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 14:40 [alsa-devel] [PATCH] ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen Jaroslav Kysela
2019-11-29 14:45 ` Takashi Iwai
2020-02-10 2:52 ` Benjamin Poirier [this message]
2020-02-10 3:04 ` Benjamin Poirier
2020-02-10 9:11 ` Kailang
2020-02-10 12:14 ` Benjamin Poirier
2020-02-10 12:54 ` Jaroslav Kysela
2020-02-11 5:41 ` Benjamin Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210025249.GA2700@f3 \
--to=benjamin.poirier@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=kailang@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).