From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD63AC352A3 for ; Thu, 13 Feb 2020 04:24:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55FA6206ED for ; Thu, 13 Feb 2020 04:24:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="AIh+ftKH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="lMpVF6tI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55FA6206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A5C811614; Thu, 13 Feb 2020 05:23:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A5C811614 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581567888; bh=UklSzqsIizfb2ZqVi/STRFoQZ51NdIBaypk0QEOPfzc=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AIh+ftKHOH2BMJOsE3o656pHON7rgO4HImOrQK1hsgfXJ3EFdsjI5VFUnciNV+Zd/ G1sFkkJYV8WBb34trNi57JJ6dOiMUSWrrlAWz+1oXMcWqpE2DgvvhUtn3CNpc0E948 LIyAo8EWGt/mAcY/9wL7p8nlvyIMJtwT+bBsedMo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2286EF8013E; Thu, 13 Feb 2020 05:23:58 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2CA68F80145; Thu, 13 Feb 2020 05:23:56 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 33691F800F0 for ; Thu, 13 Feb 2020 05:23:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 33691F800F0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="lMpVF6tI" Received: from localhost (unknown [106.201.58.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93A87206ED; Thu, 13 Feb 2020 04:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581567830; bh=oFuIKIBbpfNJBIKi9hk26HAIHYBy5AhoYQE6BtbHQ9g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lMpVF6tIkzuSqTk30LsQb7Tf+42ncsEE9P1Dn7O+0GWQ/HLAEtHpecBJaBseE/iJJ 7UsYE+9ClL8TrQAnSG+ARtHxSvTfTVEhLF7sz5s2dfMHW/FhSS/CSc1S0niFxNkY/e nVZTLYtnEYnA+2Vf0pq9rbPMp+hhNwYPr3oHdD2Q= Date: Thu, 13 Feb 2020 09:53:44 +0530 From: Vinod Koul To: Pierre-Louis Bossart Message-ID: <20200213042344.GC2618@vkoul-mobl> References: <20200114234257.14336-1-pierre-louis.bossart@linux.intel.com> <20200114234257.14336-6-pierre-louis.bossart@linux.intel.com> <20200212101554.GB2618@vkoul-mobl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Bard liao , Rander Wang Subject: Re: [alsa-devel] [PATCH v2 5/5] soundwire: intel: free all resources on hw_free() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12-02-20, 09:37, Pierre-Louis Bossart wrote: > Hi Vinod, > > > > +static int intel_free_stream(struct sdw_intel *sdw, > > > + struct snd_pcm_substream *substream, > > > + struct snd_soc_dai *dai, > > > + int link_id) > > > +{ > > > + struct sdw_intel_link_res *res = sdw->link_res; > > > + struct sdw_intel_stream_free_data free_data; > > > > where is this struct sdw_intel_stream_free_data defined. I dont see it > > in this patch or this series.. > > the definition is already upstream :-) Oops did i look at wrong branch, sorry! > > > + ret = intel_free_stream(sdw, substream, dai, sdw->instance); > > > + if (ret < 0) { > > > + dev_err(dai->dev, "intel_free_stream: failed %d", ret); > > > + return ret; > > > + } > > > + > > > + sdw_release_stream(dma->stream); > > > > I think, free the 'name' here would be apt > > Right, this is something we discussed with Rander shortly before Chinese New > Year and we wanted to handle this with a follow-up patch, would that work > for you? if not I can send a v3, your choice. It would be better if we fix this up in this series :) -- ~Vinod _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel