alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [alsa-devel] [PATCH 0/3] ASoC: max98090: revert invalid fixes
@ 2020-02-14 10:57 Tzung-Bi Shih
  2020-02-14 10:57 ` [alsa-devel] [PATCH 1/3] ASoC: max98090: revert invalid fix for handling SHDN Tzung-Bi Shih
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Tzung-Bi Shih @ 2020-02-14 10:57 UTC (permalink / raw)
  To: broonie; +Cc: tzungbi, alsa-devel, dgreid, cychiang

A critical side-effect was observed along with the commit 62d5ae4cafb7
("ASoC: max98090: save and restore SHDN when changing sensitive registers").

When keep playing something,
(e.g. sox -n -t s16 -r 48000 -c 2 - synth sine 440 vol 0.1 | \
      aplay -D hw:0,0 -f S16_LE -r 48000 -c 2)

the recorded sound has chance to break (clipping).
(e.g. while [ 1 ]; do
        arecord -q -f S16_LE -d 2 -r 48000 -c 2 test.raw \
	sox -t s16 -r 48000 -c 2 test.raw  -n stat \
	...
      done)

The series reverts all related commits.
I feel really sorry for the whole mess.

Tzung-Bi Shih (3):
  ASoC: max98090: revert invalid fix for handling SHDN
  ASoC: dapm: remove snd_soc_dapm_put_enum_double_locked
  ASoC: core: remove SND_SOC_BYTES_E

 include/sound/soc-dapm.h    |   2 -
 include/sound/soc.h         |   6 -
 sound/soc/codecs/max98090.c | 434 ++++++++++--------------------------
 sound/soc/codecs/max98090.h |   3 +-
 sound/soc/soc-dapm.c        |  54 ++---
 5 files changed, 137 insertions(+), 362 deletions(-)

-- 
2.25.0.265.gbab2e86ba0-goog

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-02-14 21:01 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 10:57 [alsa-devel] [PATCH 0/3] ASoC: max98090: revert invalid fixes Tzung-Bi Shih
2020-02-14 10:57 ` [alsa-devel] [PATCH 1/3] ASoC: max98090: revert invalid fix for handling SHDN Tzung-Bi Shih
2020-02-14 20:56   ` [alsa-devel] Applied "ASoC: max98090: revert invalid fix for handling SHDN" to the asoc tree Mark Brown
2020-02-14 10:57 ` [alsa-devel] [PATCH 2/3] ASoC: dapm: remove snd_soc_dapm_put_enum_double_locked Tzung-Bi Shih
2020-02-14 20:56   ` [alsa-devel] Applied "ASoC: dapm: remove snd_soc_dapm_put_enum_double_locked" to the asoc tree Mark Brown
2020-02-14 10:57 ` [alsa-devel] [PATCH 3/3] ASoC: core: remove SND_SOC_BYTES_E Tzung-Bi Shih
2020-02-14 15:43   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).