From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F1DC35254 for ; Mon, 17 Feb 2020 12:37:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BD8A207FD for ; Mon, 17 Feb 2020 12:37:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ntE2o5AS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BD8A207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9A8791657; Mon, 17 Feb 2020 13:36:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9A8791657 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581943069; bh=ydifzsJ40KU0yQFS5L7E9psBLEjJmYBfvnPBxZQejfs=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ntE2o5AS8oE+1MnaerP7SVLdQr+PY/f7mYtpS1WLh4ofhfo9TotPwgc7LfD0XPkkF HYBeYgqk4h+tHGBNDyxPIEWttUXgg1cQ1J/+0RtGJT5bKaCkDnwAI/DhQJMuqnKWdo 9WYNFZSabMHiI33rZ9ZelpnkXR1Mgp8XFnwhh0uc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1F962F8015E; Mon, 17 Feb 2020 13:36:59 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7DDA4F80172; Mon, 17 Feb 2020 13:36:57 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id A8DD5F800B6 for ; Mon, 17 Feb 2020 13:36:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A8DD5F800B6 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30CBB30E; Mon, 17 Feb 2020 04:36:52 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A84553F703; Mon, 17 Feb 2020 04:36:51 -0800 (PST) Date: Mon, 17 Feb 2020 12:36:50 +0000 From: Mark Brown To: Derek =?utf-8?B?W+aWueW+t+e+qV0=?= Message-ID: <20200217123650.GD9304@sirena.org.uk> References: <1581666814-6380-1-git-send-email-derek.fang@realtek.com> <20200214123803.GG4827@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Oder Chiou , Jack Yu , "alsa-devel@alsa-project.org" , "lars@metafoo.de" , "lgirdwood@gmail.com" , Albert Chen , Shuming =?utf-8?B?W+iMg+abuOmKmF0=?= , "Flove\(HsinFu\)" Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: rt5682: Add CCF usage for providing I2S clks X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5898061874182434278==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============5898061874182434278== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/3yNEOqWowh/8j+e" Content-Disposition: inline --/3yNEOqWowh/8j+e Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 17, 2020 at 10:59:55AM +0000, Derek [=E6=96=B9=E5=BE=B7=E7=BE= =A9] wrote: > > Subject: Re: [PATCH 1/2] ASoC: rt5682: Add CCF usage for providing I2S = clks > > > + if (parent_rate !=3D CLK_PLL2_FIN) > > > + dev_warn(component->dev, "clk %s only support %d Hz input\n", > > > + clk_name, CLK_PLL2_FIN); > > > + if (rate !=3D CLK_48) { > > > + dev_warn(component->dev, "clk %s only support %d Hz output\n", > > > + clk_name, CLK_48); > > > + rate =3D CLK_48; > > > + } > > Are these genuine restrictions of the hardware or is this just being > > hard coded in the driver? > It's hard coded for an application case. > Generate a 48kHz clk with a parent 48 MHz clk. I see... obviously this is really not good quality of implementation although it doesn't actually break any external interfaces so I guess we could take it. I would at least want to see some clear comments in both the code and the changelog explaining that this limitation is just a temporary hack until a better implementation is done though. --/3yNEOqWowh/8j+e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5KiOEACgkQJNaLcl1U h9DMXQf+Kon4Z0ajfBKari7ZjfJBGGoDxE3CDeiCPfGliI89G4zGAZkg4rOyrNkE xnvk5TsRwBCe+yYRz6PXukm8FXIV6Th0tcABe/KzKfSfsJpk7T0Mmez2Yz++SNKa QKOHFXF2AGtXFhbfQ6eq6nj9d+9es49KWBixzf6HBrpBrqoGCGmK/eUcmvggjEgs tOq3WIDTjHnSvR1Zt/I15u0O46NVQ2jwvwP2htvHVcrId2Kk3lInSkXl3mMshqf6 Lio0vKQ4mSkgLOPXh+tUlYWRBpLfrbZFLFRLvoZnD5aUCB9aZ3UaFvFzy17cUL5W ldYn9lt0R26U9RgCzF1jAkgxQDaaRQ== =L9HC -----END PGP SIGNATURE----- --/3yNEOqWowh/8j+e-- --===============5898061874182434278== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============5898061874182434278==--