From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B5DEC34022 for ; Mon, 17 Feb 2020 23:37:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA88D207FD for ; Mon, 17 Feb 2020 23:37:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="FXuHC7ut" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA88D207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0C7AA829; Tue, 18 Feb 2020 00:36:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0C7AA829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581982655; bh=lSLMhe+7VCVLcP5B1FoHJfF7pENKybzRI1BJAnOg6kw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FXuHC7utoAyUebjb79xtL9ZjJMcR7WAX+Uvy2PBCy0fP6z9ZoFqvNTpkETcveDPV8 O9WH9IGJ7bLh4tIrxMv82gtlFb0Wj59vQsDsFqxsRsMxJ10ilafjTF30gDUnRzMD05 c2DaioNAs8nKyMdvSOmLC0lspirA+Qvr1fKR2pyQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 83E92F8015E; Tue, 18 Feb 2020 00:36:44 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A9081F80172; Tue, 18 Feb 2020 00:36:41 +0100 (CET) Received: from muru.com (muru.com [72.249.23.125]) by alsa1.perex.cz (Postfix) with ESMTP id 7198AF800B6 for ; Tue, 18 Feb 2020 00:36:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7198AF800B6 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 20F528087; Mon, 17 Feb 2020 23:37:11 +0000 (UTC) Date: Mon, 17 Feb 2020 15:36:23 -0800 From: Tony Lindgren To: Peter Ujfalusi Subject: Re: [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card Message-ID: <20200217233623.GE35972@atomide.com> References: <20200211171645.41990-1-tony@atomide.com> <20200212143543.GI64767@atomide.com> <346dfd2b-23f8-87e0-6f45-27a5099b1066@ti.com> <20200214170322.GZ64767@atomide.com> <20200217231001.GC35972@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217231001.GC35972@atomide.com> Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, Kuninori Morimoto , Aaro Koskinen , linux-kernel@vger.kernel.org, Merlijn Wajer , Takashi Iwai , Liam Girdwood , Mark Brown , Pavel Machek , Sebastian Reichel , "Arthur D ." , Jarkko Nikula X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" * Tony Lindgren [200217 23:10]: > * Peter Ujfalusi [200217 12:10]: > > On 14/02/2020 19.03, Tony Lindgren wrote: > > > But right now in droid4 voice call case mcbsp is just the i2s transport, > > > and everything happens betwee the modem and the cpcap pmic. > > > > Iow you don't need McBSP DAI at all. If you would have added the dummy > > codec to McBSP !3 and use that, it would work in a same way, or to DMIC > > or McPDM... > > > > The McBSP ops are NULL for the dummy dai, so McBSP is turned off. > > Hmm yeah I don't know if the cpcap codec on the same mcbsp needs > mcbsp for voice call. > > According to Sebastian sounds like mcbsp can be idle at that point. > > But what about capture of voice call at the mcbsp from the > TDM slot? In that case mcbsp would be active. Looks like only initializing only one mcbsp3 instance here instead of two will produce an oops as below. I'm not sure how this is supposed to work for snd-soc-audio-graph-card with multipe endpoints connected to just one mcbsp dai instance? Regards, Tony 8< ------------------- Internal error: Oops: 805 [#1] PREEMPT SMP ARM snd_soc_del_component_unlocked+0xf4/0x110 ... [ 39.616027] Backtrace: [ 39.616149] [] (snd_soc_del_component_unlocked [snd_soc_core]) from [] (snd_soc_add_component+0x238/0x374 [snd_s) [ 39.616149] r7:00000002 r6:00000002 r5:ec9a0e78 r4:00000122 [ 39.678283] qmi_wwan 1-1:1.6: cdc-wdm1: USB WDM device [ 39.739074] [] (snd_soc_add_component [snd_soc_core]) from [] (snd_soc_register_component+0x50/0x60 [snd_soc_cor) [ 39.739074] r10:bf4582d0 r9:ec9d0840 r8:00000002 r7:00000002 r6:ec9d0640 r5:bf4584ac [ 39.800842] asoc-audio-graph-card soundcard: using device tree for GPIO lookup [ 39.808685] r4:eed52410 [ 39.862304] [] (snd_soc_register_component [snd_soc_core]) from [] (devm_snd_soc_register_component+0x54/0x90 [s) [ 39.862304] r7:ec9d0640 r6:bf4584ac r5:ec9d3040 r4:eed52410 [ 39.925048] qmi_wwan 1-1:1.6 wwan1: register 'qmi_wwan' at usb-4a064800.ohci-1, WWAN/QMI device, 2e:59:df:3f:4f:ef [ 39.984558] [] (devm_snd_soc_register_component [snd_soc_core]) from [] (asoc_mcbsp_probe+0x3e8/0x574 [snd_soc_o) [ 39.984558] r9:ec9d0840 r8:ec9f4000 r7:eed52410 r6:00000000 r5:eed52400 r4:ec9d0840 [ 39.984588] [] (asoc_mcbsp_probe [snd_soc_omap_mcbsp]) from [] (platform_drv_probe+0x58/0xa8) [ 39.984619] r10:00000000 r9:0000002e r8:bf459014 r7:00000000 r6:bf459014 r5:00000000 [ 40.044342] of_get_named_gpiod_flags: can't parse 'pa-gpios' property of node '/soundcard[0]' [ 40.051788] r4:eed52410 [ 40.100769] [] (platform_drv_probe) from [] (really_probe+0x1ec/0x358)