From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7658FC10DCE for ; Fri, 13 Mar 2020 12:10:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0695A20746 for ; Fri, 13 Mar 2020 12:10:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="i3c8vSeo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="qgnRt+b/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0695A20746 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 49B1617DA; Fri, 13 Mar 2020 13:09:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 49B1617DA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584101411; bh=FRa0vUMY00wqxM+1wwiVDeYxb3H2CyA1MXAd8PoEAqM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=i3c8vSeoRY+ntocdj1Wq+QP2y5c9KdvPO5CNOSc6ZKn8PRLn3vTQWuR0fYmMUVL8y 776SE1zjorsJ5M8wRAMVY4+hifiWtrar6RXbI9q8w6zksr8Yz/2h1mKjIor+HiMLkd zocABO+Np7lNGob8o7hOL/QkVUEVG/exmJzU33z4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D340CF801A3; Fri, 13 Mar 2020 13:09:20 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 36FD6F801EB; Fri, 13 Mar 2020 13:09:08 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BCDBAF80086 for ; Fri, 13 Mar 2020 13:09:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BCDBAF80086 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="qgnRt+b/" Received: from localhost (unknown [171.76.107.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20DEA206FA; Fri, 13 Mar 2020 12:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584101339; bh=FRa0vUMY00wqxM+1wwiVDeYxb3H2CyA1MXAd8PoEAqM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qgnRt+b/NSu/QOnEyTptYZF0XcwUfNV2DiUab8515WdLxCmV2k2ngysUzM4VnGuss Sx3nA9NpVsvTwE9ZgxUmd9GrxLOjHC1swJyfYquNcFD6C7k4NAgksCn6+Z0tNsEqKK cRGFlv8E1i9oOS5ykT5JMl1J5naLGftuQDY8hTuM= Date: Fri, 13 Mar 2020 17:38:55 +0530 From: Vinod Koul To: Pierre-Louis Bossart Subject: Re: [PATCH 04/16] soundwire: cadence: handle error cases with CONFIG_UPDATE Message-ID: <20200313120855.GF4885@vkoul-mobl> References: <20200311184128.4212-1-pierre-louis.bossart@linux.intel.com> <20200311184128.4212-5-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311184128.4212-5-pierre-louis.bossart@linux.intel.com> Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , Hui Wang , broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Bard liao , Rander Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 11-03-20, 13:41, Pierre-Louis Bossart wrote: > config_update() may time out or cannot be use in ClockStopMode > > Signed-off-by: Pierre-Louis Bossart > --- > drivers/soundwire/cadence_master.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c > index 71cba2585151..4089c271305a 100644 > --- a/drivers/soundwire/cadence_master.c > +++ b/drivers/soundwire/cadence_master.c > @@ -239,6 +239,11 @@ static int cdns_config_update(struct sdw_cdns *cdns) > { > int ret; > > + if (sdw_cdns_is_clock_stop(cdns)) { > + dev_err(cdns->dev, "Cannot program MCP_CONFIG_UPDATE in ClockStopMode\n"); This looks fine but duplicates the log, so maybe you can remove from here or preceding patch... Or use single line as I suggested in that patch and keep this as is. -- ~Vinod