From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F8CC43331 for ; Sun, 29 Mar 2020 07:58:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51A79206CC for ; Sun, 29 Mar 2020 07:58:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="gVbciLpR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51A79206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B5C761682; Sun, 29 Mar 2020 09:58:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B5C761682 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1585468737; bh=UMmSUJx88sBu0N9nOKRtBPLcSHg6XROAcLmALvIEO08=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gVbciLpRiMUq4FxvBsOWmDWZZSG4L+gU5VFKWoE3xPZic/rrIU2STx2F6KqVG29Ik KFsuD7Eu/1nUn+zyE8J5mUkNlmLvHdESHebLYJAvUnkBLjEYqziJspEhW5TIHCDBoZ wUOINErCmdvuDYgUat74/zPvUdO9njNVn4JW4ZuE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AD9C0F802A1; Sun, 29 Mar 2020 09:54:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AD7D3F80227; Thu, 26 Mar 2020 09:34:30 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3E006F8011E for ; Thu, 26 Mar 2020 09:34:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3E006F8011E IronPort-SDR: fwQN7fcbcdQ49VcU8gSe72uzM1RppRq5Ut65H3XNh7pd6b8N1p8fM0qClauB6bE3COtAupD2Wl shp4JQ63mwqA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 01:34:21 -0700 IronPort-SDR: nly9xD30xpsmGWYFWXpCQfSK56dqJFIPOST3nuhEheHKExNfIQ5XgPc3HXfYowGvGJpdixXyaW B8k9bFVtCr9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,307,1580803200"; d="scan'208";a="446919804" Received: from shao2-debian.sh.intel.com (HELO localhost) ([10.239.13.3]) by fmsmga005.fm.intel.com with ESMTP; 26 Mar 2020 01:34:13 -0700 Date: Thu, 26 Mar 2020 16:33:55 +0800 From: kernel test robot To: Thomas Gleixner Subject: Re: [cpufreq] 06c4d00466: will-it-scale.per_process_ops -53.4% regression Message-ID: <20200326083355.GO11705@shao2-debian> References: <20200320131509.564059710@linutronix.de> <20200324060124.GC11705@shao2-debian> <43a4189a-7153-18e8-4657-4a4400002c05@intel.com> <87zhc4ybbt.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87zhc4ybbt.fsf@nanos.tec.linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Sun, 29 Mar 2020 09:54:17 +0200 Cc: Ulf Hansson , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Viresh Kumar , ALSA Development Mailing List , Platform Driver , Jacob Pan , Srinivas Pandruvada , Amit Kucheria , Mark Gross , Herbert Xu , Chanwoo Choi , Daniel Lezcano , ACPI Devel Maling List , Andy Shevchenko , linux-pci@vger.kernel.org, Darren Hart , Zhang Rui , Guenter Roeck , Len Brown , Jean Delvare , Linux PM , linux-mmc , lkp@lists.01.org, Bjorn Helgaas , Takashi Iwai , Adrian Hunter , linux-edac@vger.kernel.org, linux-hwmon@vger.kernel.org, Tony Luck , Greg Kroah-Hartman , "Rafael J. Wysocki" , LKML , linux-crypto , Paolo Bonzini , "David S. Miller" , Andy Shevchenko X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Mar 25, 2020 at 11:32:06AM +0100, Thomas Gleixner wrote: > Rong Chen writes: > > On 3/24/20 6:24 PM, Andy Shevchenko wrote: > >> On Tue, Mar 24, 2020 at 8:02 AM kernel test robot wrote: > >>> Greeting, > >>> > >>> FYI, we noticed a -53.4% regression of will-it-scale.per_process_ops due to commit: > >>> commit: 06c4d00466eb374841bc84c39af19b3161ff6917 ("[patch 09/22] cpufreq: Convert to new X86 CPU match macros") > >>> url: https://github.com/0day-ci/linux/commits/Thomas-Gleixner/x86-devicetable-Move-x86-specific-macro-out-of-generic-code/20200321-031729 > >>> base: https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git linux-next > >>> > >>> in testcase: will-it-scale > >>> on test machine: 4 threads Intel(R) Core(TM) i3-3220 CPU @ 3.30GHz with 8G memory > >>> with following parameters: > >> > >> drivers/cpufreq/speedstep-centrino.c change missed the terminator, > >> perhaps it's a culprit, because I don't believe removing dups and > >> reordering lines may affect this. > >> Can you restore terminator there and re-test? > >> > > > > I have retested with the change, but it has no effect on the performance. > > Bah. The binary equivalence testing detected this, but I obvioulsy > missed it. Delta fix below. > > Thanks, > > tglx > > 8<-------------- > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -2727,7 +2727,7 @@ static inline void intel_pstate_request_ > > #define X86_MATCH_HWP(model, hwp_mode) \ > X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 6, INTEL_FAM6_##model, \ > - X86_FEATURE_APERFMPERF, hwp_mode) > + X86_FEATURE_HWP, hwp_mode) > > static const struct x86_cpu_id hwp_support_ids[] __initconst = { > X86_MATCH_HWP(BROADWELL_X, INTEL_PSTATE_HWP_BROADWELL), Hi Thomas, The patch can fix the regression: commit: 06c4d00466 ("cpufreq: Convert to new X86 CPU match macros") d369f9be1a ("the fix patch") 06c4d00466eb3748 d369f9be1ad1e22da4e8f03557 testcase/testparams/testbox ---------------- -------------------------- --------------------------- %stddev change %stddev \ | \ 93200 114% 199599 will-it-scale/performance-process-16-read2-ucode=0x21/lkp-ivb-d02 93200 114% 199599 GEO-MEAN will-it-scale.per_process_ops Best Regards, Rong Chen