From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsactl: avoid needless wakeups in monitor loop.
Date: Sun, 12 Apr 2020 11:19:06 +0900 [thread overview]
Message-ID: <20200412021905.GB3961@workstation> (raw)
In-Reply-To: <20191015043802.23619-1-zev@bewilderbeest.net>
Hi,
On Mon, Oct 14, 2019 at 11:38:02PM -0500, Zev Weiss wrote:
> The timeout wasn't really being used for anything; disabling it should
> reduce idle energy consumption slightly.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
> alsactl/monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I overlooked it as well... It looks good to me.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/alsactl/monitor.c b/alsactl/monitor.c
> index 6b090e4f5c92..6d9328d899a4 100644
> --- a/alsactl/monitor.c
> +++ b/alsactl/monitor.c
> @@ -340,7 +340,7 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs,
> int count;
> int i;
>
> - count = epoll_wait(epfd, epev, max_ev_count, 200);
> + count = epoll_wait(epfd, epev, max_ev_count, -1);
> if (count < 0) {
> err = count;
> break;
> --
> 2.23.0
Regards
Takashi Sakamoto
next prev parent reply other threads:[~2020-04-12 2:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 4:38 [alsa-devel] [PATCH] alsactl: avoid needless wakeups in monitor loop Zev Weiss
2020-04-11 22:51 ` Zev Weiss
2020-04-12 2:19 ` Takashi Sakamoto [this message]
2020-04-14 13:24 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200412021905.GB3961@workstation \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).