From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C9AC2BA2B for ; Sun, 19 Apr 2020 06:03:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE6432076A for ; Sun, 19 Apr 2020 06:03:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="i3bwwaSb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pTMv1wOD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE6432076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F096A15F2; Sun, 19 Apr 2020 08:03:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F096A15F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587276237; bh=r2AgjpwBy563/SvDhTEdOgTQsrTjb6KChd2dLbtCIIs=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=i3bwwaSbXAgyN39leojhgtMH50gIRQSENy0ZA3Zy0ReIAg/gX188ZCyvgfLA2ptf4 VbVM1taoxtQXj/9hhq9kJcATiG2rGwJ9kxRMG3Tsu7om9PpwSH1qLrndWm3NzOVRXC It1MjzAVEqRDgGwZ9NkWzVV4v8tOk7FBFB+9CsFM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8C722F80143; Sun, 19 Apr 2020 08:03:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 00539F801EC; Sun, 19 Apr 2020 08:03:02 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 477EDF800BA for ; Sun, 19 Apr 2020 08:02:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 477EDF800BA Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pTMv1wOD" Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4A4B2076A; Sun, 19 Apr 2020 06:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587276170; bh=r2AgjpwBy563/SvDhTEdOgTQsrTjb6KChd2dLbtCIIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pTMv1wODwFpdjz0FVgzA+p2WSCpvCxj18+/q3aiIPhhtKR+jsjHHIdl5zJ2q2+RA3 +Tdmi8jGAiqk3VTvUYzIU3dTg9Q3SKwo6y6sZDkWyGvygbRRccfGpH1VpT4kAcKc5E 4lTNQxLSLwDJyeMo2kAEPugwsa59XjBdxg3VhiTs= Date: Sun, 19 Apr 2020 08:02:47 +0200 From: Greg Kroah-Hartman To: Randy Dunlap Subject: Re: [PATCH 7/9] drivers/base: fix empty-body warnings in devcoredump.c Message-ID: <20200419060247.GA3535909@kroah.com> References: <20200418184111.13401-1-rdunlap@infradead.org> <20200418184111.13401-8-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200418184111.13401-8-rdunlap@infradead.org> Cc: alsa-devel@alsa-project.org, Dmitry Torokhov , Zzy Wysm , linux-kernel@vger.kernel.org, "J. Bruce Fields" , target-devel@vger.kernel.org, Dave Jiang , linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, Vishal Verma , linux-input@vger.kernel.org, Alexander Viro , Dan Williams , Andrew Morton , linux-nfs@vger.kernel.org, "Martin K. Petersen" , linux-usb@vger.kernel.org, Takashi Iwai , Chuck Lever , linux-fsdevel@vger.kernel.org, Johannes Berg , Linus Torvalds X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, Apr 18, 2020 at 11:41:09AM -0700, Randy Dunlap wrote: > Fix gcc empty-body warning when -Wextra is used: > > ../drivers/base/devcoredump.c:297:42: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] > ../drivers/base/devcoredump.c:301:42: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] > > Signed-off-by: Randy Dunlap > Cc: Johannes Berg > Cc: Linus Torvalds > Cc: Andrew Morton > --- > drivers/base/devcoredump.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > --- linux-next-20200417.orig/drivers/base/devcoredump.c > +++ linux-next-20200417/drivers/base/devcoredump.c > @@ -9,6 +9,7 @@ > * > * Author: Johannes Berg > */ > +#include Why the need for this .h file being added for reformatting the code? thanks, greg k-h