From: Oscar Carter <oscar.carter@gmx.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org,
linux1394-devel@lists.sourceforge.net,
Oscar Carter <oscar.carter@gmx.com>,
Kees Cook <keescook@chromium.org>,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org,
Clemens Ladisch <clemens@ladisch.de>,
Takashi Iwai <tiwai@suse.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
"Lev R . Oshvang ." <levonshe@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] firewire: Remove function callback casts
Date: Fri, 22 May 2020 19:43:08 +0200 [thread overview]
Message-ID: <20200522174308.GB3059@ubuntu> (raw)
In-Reply-To: <20200520061624.GA25690@workstation>
Hi,
On Wed, May 20, 2020 at 03:16:24PM +0900, Takashi Sakamoto wrote:
> Hi,
>
> I'm an author of ALSA firewire stack and thanks for the patch. I agree with
> your intention to remove the cast of function callback toward CFI build.
>
> Practically, the isochronous context with FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL
> is never used by in-kernel drivers. Here, I propose to leave current
> kernel API (fw_iso_context_create() with fw_iso_callback_t) as is.
> Alternatively, a new kernel API for the context (e.g.
> fw_iso_mc_context_create() with fw_iso_mc_callback_t). This idea leaves
> current drivers as is and the change is done inner firewire-core driver,
> therefore existent kernel API is not changed.
>
It sounds good to me.
> Later I post two patches for the proposal. I'd like you to review it and
> I'm glad to receive your comments.
>
I will take a look at your proposal. Thanks for your time and work.
>
> Regards
>
> Takashi Sakamoto
Thanks,
Oscar Carter
next prev parent reply other threads:[~2020-05-22 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 17:34 [PATCH v2] firewire: Remove function callback casts Oscar Carter
2020-05-20 6:16 ` Takashi Sakamoto
2020-05-22 17:43 ` Oscar Carter [this message]
2020-05-23 6:10 ` greg
2020-05-23 6:10 ` Greg KH
2020-05-23 7:58 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522174308.GB3059@ubuntu \
--to=oscar.carter@gmx.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=levonshe@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=mchehab@kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).