Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v3 2/7] ASoC: soc-link: move soc_rtd_xxx()
Date: Fri, 22 May 2020 19:37:11 +0100
Message-ID: <20200522183711.GQ5801@sirena.org.uk> (raw)
In-Reply-To: <87imgo4yij.wl-kuninori.morimoto.gx@renesas.com>


[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

On Fri, May 22, 2020 at 09:13:56AM +0900, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> dai_link related function should be implemented at
> soc-link.c.
> This patch moves soc-pcm soc_rtd_xxx()
> to soc-link as snd_soc_link_xxx()

This breaks bisection on x86 allmodconfig:

/mnt/kernel/sound/soc/soc-pcm.c: In function 'soc_pcm_open':
/mnt/kernel/sound/soc/soc-pcm.c:733:29: error: passing argument 1 of 'snd_soc_link_startup' from incompatible pointer type [-Werror=incompatible-pointer-types]
  ret = snd_soc_link_startup(substream);
                             ^~~~~~~~~
In file included from /mnt/kernel/sound/soc/soc-pcm.c:27:
/mnt/kernel/include/sound/soc-link.h:12:54: note: expected 'struct snd_soc_pcm_runtime *' but argument is of type 'struct snd_pcm_substream *'
 int snd_soc_link_startup(struct snd_soc_pcm_runtime *rtd,
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
/mnt/kernel/sound/soc/soc-pcm.c:733:8: error: too few arguments to function 'snd_soc_link_startup'
  ret = snd_soc_link_startup(substream);
        ^~~~~~~~~~~~~~~~~~~~

(and some more)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  0:13 [PATCH v3 0/7] ASoC: add soc-link Kuninori Morimoto
2020-05-22  0:13 ` [PATCH v3 1/7] ASoC: add soc-link.c Kuninori Morimoto
2020-05-22  0:13 ` [PATCH v3 2/7] ASoC: soc-link: move soc_rtd_xxx() Kuninori Morimoto
2020-05-22 18:37   ` Mark Brown [this message]
2020-05-25  0:34     ` Kuninori Morimoto
2020-05-22  0:14 ` [PATCH v3 3/7] ASoC: soc-link: remove unneeded parameter from snd_soc_link_xxx() Kuninori Morimoto
2020-05-22  0:14 ` [PATCH v3 4/7] ASoC: soc-link: add snd_soc_link_be_hw_params_fixup() Kuninori Morimoto
2020-05-22  0:14 ` [PATCH v3 5/7] ASoC: soc-link: add snd_soc_link_compr_startup() Kuninori Morimoto
2020-05-22  0:14 ` [PATCH v3 6/7] ASoC: soc-link: add snd_soc_link_compr_shutdown() Kuninori Morimoto
2020-05-22  0:14 ` [PATCH v3 7/7] ASoC: soc-link: add snd_soc_link_compr_set_params() Kuninori Morimoto
2020-05-22  0:21 ` [PATCH v3 0/7] ASoC: add soc-link Kuninori Morimoto
2020-05-22 14:36 ` Pierre-Louis Bossart
2020-05-25 14:57 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522183711.GQ5801@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git