From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Ola Lilja <ola.o.lilja@stericsson.com>,
tiwai@suse.de, Lee Jones <lee.jones@linaro.org>,
Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Roger Nilsson <roger.xr.nilsson@stericsson.com>,
broonie@kernel.org, Sandeep Kaushik <sandeep.kaushik@st.com>,
zhong jiang <zhongjiang@huawei.com>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 05/10] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR'
Date: Tue, 7 Jul 2020 14:16:10 -0500 [thread overview]
Message-ID: <20200707191615.98296-6-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200707191615.98296-1-pierre-louis.bossart@linux.intel.com>
From: Lee Jones <lee.jones@linaro.org>
Looks like these have been unchecked since the driver's inception in 2012.
Fixes the following W=1 kernel build warning(s):
sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_rx’:
sound/soc/ux500/ux500_msp_i2s.c:398:6: warning: variable ‘reg_val_DR’ set but not used [-Wunused-but-set-variable]
sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_tx’:
sound/soc/ux500/ux500_msp_i2s.c:415:6: warning: variable ‘reg_val_TSTDR’ set but not used [-Wunused-but-set-variable]
Cc: zhong jiang <zhongjiang@huawei.com>
Cc: Ola Lilja <ola.o.lilja@stericsson.com>
Cc: Roger Nilsson <roger.xr.nilsson@stericsson.com>
Cc: Sandeep Kaushik <sandeep.kaushik@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/ux500/ux500_msp_i2s.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 394d8b2a4a16..fd0b88bb7921 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -395,7 +395,7 @@ static int enable_msp(struct ux500_msp *msp, struct ux500_msp_config *config)
static void flush_fifo_rx(struct ux500_msp *msp)
{
- u32 reg_val_DR, reg_val_GCR, reg_val_FLR;
+ u32 reg_val_GCR, reg_val_FLR;
u32 limit = 32;
reg_val_GCR = readl(msp->registers + MSP_GCR);
@@ -403,7 +403,7 @@ static void flush_fifo_rx(struct ux500_msp *msp)
reg_val_FLR = readl(msp->registers + MSP_FLR);
while (!(reg_val_FLR & RX_FIFO_EMPTY) && limit--) {
- reg_val_DR = readl(msp->registers + MSP_DR);
+ readl(msp->registers + MSP_DR);
reg_val_FLR = readl(msp->registers + MSP_FLR);
}
@@ -412,7 +412,7 @@ static void flush_fifo_rx(struct ux500_msp *msp)
static void flush_fifo_tx(struct ux500_msp *msp)
{
- u32 reg_val_TSTDR, reg_val_GCR, reg_val_FLR;
+ u32 reg_val_GCR, reg_val_FLR;
u32 limit = 32;
reg_val_GCR = readl(msp->registers + MSP_GCR);
@@ -421,7 +421,7 @@ static void flush_fifo_tx(struct ux500_msp *msp)
reg_val_FLR = readl(msp->registers + MSP_FLR);
while (!(reg_val_FLR & TX_FIFO_EMPTY) && limit--) {
- reg_val_TSTDR = readl(msp->registers + MSP_TSTDR);
+ readl(msp->registers + MSP_TSTDR);
reg_val_FLR = readl(msp->registers + MSP_FLR);
}
writel(0x0, msp->registers + MSP_ITCR);
--
2.25.1
next prev parent reply other threads:[~2020-07-07 19:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 19:16 [PATCH v3 00/10] ASoC: Clean-up W=1 build warnings - part2 Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 01/10] ASoC: qcom: q6asm: fix kernel-doc Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 02/10] ASoC: sunxi: sun4i-i2s: " Pierre-Louis Bossart
2020-07-08 8:11 ` Maxime Ripard
2020-07-07 19:16 ` [PATCH v3 03/10] ASoC: sunxi: sun4i-spdif: " Pierre-Louis Bossart
2020-07-08 8:12 ` Maxime Ripard
2020-07-07 19:16 ` [PATCH v3 04/10] ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header Pierre-Louis Bossart
2020-07-07 19:16 ` Pierre-Louis Bossart [this message]
2020-07-07 19:16 ` [PATCH v3 06/10] ASoC: sti: uniperif: fix 'defined by not used' warning Pierre-Louis Bossart
2020-07-08 9:11 ` Arnaud POULIQUEN
2020-07-08 12:55 ` Pierre-Louis Bossart
2020-07-08 13:33 ` Arnaud POULIQUEN
2020-07-07 19:16 ` [PATCH v3 07/10] ASoC: codecs: rt5631: fix kernel-doc Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 08/10] ASoC: codecs: rt5659: Remove many unused const variables Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 09/10] ASoC: codecs: tlv320aic26: fix kernel-doc warning Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 10/10] ASoC: codecs: ak4458: Remove set but never checked variable 'ret' Pierre-Louis Bossart
2020-07-08 6:39 ` [PATCH v3 00/10] ASoC: Clean-up W=1 build warnings - part2 Lee Jones
2020-07-08 12:59 ` Pierre-Louis Bossart
2020-07-08 13:06 ` Lee Jones
2020-07-08 13:38 ` Mark Brown
2020-07-08 13:50 ` Lee Jones
2020-07-08 14:42 ` Mark Brown
2020-07-10 15:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707191615.98296-6-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ola.o.lilja@stericsson.com \
--cc=roger.xr.nilsson@stericsson.com \
--cc=sandeep.kaushik@st.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).