From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C289C433E3 for ; Thu, 23 Jul 2020 04:48:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF63120768 for ; Thu, 23 Jul 2020 04:48:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="muA8JGpl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="P3CZDCC9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF63120768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3A96686F; Thu, 23 Jul 2020 06:47:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3A96686F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595479719; bh=fy1TB8rjpKHadG1jVEEzeFm3kN+ZDLJr33KVmJVqxI0=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=muA8JGplqngxUWrfgnz+lfz0iJXRtqnl8fdPxU073pQ7DQlZxRuKTAlq7VIaYfMkm rmdG0nL54G+snvuLfynZ/Wprp5j9dZgclb+Xc+WOBTK9UL5KQ6R806QMZ6VlzpZbtr MCdhA+Oga62BcP97kJ2Z4ZUaDrsUGpfjxCul4Tfo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A0697F800CE; Thu, 23 Jul 2020 06:47:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE6A9F80212; Thu, 23 Jul 2020 06:47:45 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B71F0F800CE for ; Thu, 23 Jul 2020 06:47:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B71F0F800CE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="P3CZDCC9" Received: from localhost (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0807420768; Thu, 23 Jul 2020 04:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595479659; bh=fy1TB8rjpKHadG1jVEEzeFm3kN+ZDLJr33KVmJVqxI0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P3CZDCC9pU2t1v8t9bgg/NiGEiQ5K9OLbJysPolh2dVRXRZ65RtzNQ7g/Jx1H77FS sYMxkgq1ENZwdSKE11kKhcvq/iSanNA2W8V+GXCHSoLzhb44bgCE8za+4CmxQO1HuQ xqt/5HZRkAqWwUwGZr52fpPOiocS1eHLvmR8goZE= Date: Thu, 23 Jul 2020 10:17:34 +0530 From: Vinod Koul To: Pierre-Louis Bossart Subject: Re: [RFC PATCH v2 2/6] ALSA: compress: add new ioctl for setting codec parameters Message-ID: <20200723044734.GU12965@vkoul-mobl> References: <20200721170007.4554-1-srinivas.kandagatla@linaro.org> <20200721170007.4554-3-srinivas.kandagatla@linaro.org> <9bbfebf9-9a70-46e3-1808-413d04aa6b2c@linaro.org> <19cfe3fe-4b99-0976-679d-28523d7b9990@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <19cfe3fe-4b99-0976-679d-28523d7b9990@linux.intel.com> Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com, tiwai@suse.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, broonie@kernel.org, Srinivas Kandagatla X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 22-07-20, 10:36, Pierre-Louis Bossart wrote: > > > > >    * and the stream properties > > > > + * @set_codec_params: Sets the compressed stream codec > > > > parameters, Optional > > > > + * This can be called in during gapless next track codec change > > > > only to set > > > > + * codec params > > > > > > Would it be clearer if this was called set_next_codec_params()? or > > > set_next_track_codec_params()? > > > > > > Having set_params() and set_codec_params() is a bit confusing since > > > the semantic difference is not captured in the callback name. > > > > set_next_track_codec_params seems more sensible as its next track params. > > Will change this in next version! > > maybe set_params() and set_next_track_params() are enough, not sure if the > codec reference helps? params typically refers to whole set of compress parameters which includes buffer information and codec parameters, so codec reference would help. -- ~Vinod